From 201acb9195c2fb2fc509fb5a29f4401195f6abf6 Mon Sep 17 00:00:00 2001 From: Lee Miller Date: Mon, 16 Sep 2024 13:10:53 +0300 Subject: [PATCH] Removed unneeded objects validation in Manager.clean_objects() --- minode/manager.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/minode/manager.py b/minode/manager.py index a03f9d6..39ec568 100644 --- a/minode/manager.py +++ b/minode/manager.py @@ -56,15 +56,11 @@ class Manager(threading.Thread): @staticmethod def clean_objects(): for vector in set(shared.objects): - if not shared.objects[vector].is_valid(): - if shared.objects[vector].is_expired(): - logging.debug( - 'Deleted expired object: %s', - base64.b16encode(vector).decode()) - else: - logging.warning( - 'Deleted invalid object: %s', - base64.b16encode(vector).decode()) + # FIXME: no need to check is_valid() here + if shared.objects[vector].is_expired(): + logging.debug( + 'Deleted expired object: %s', + base64.b16encode(vector).decode()) with shared.objects_lock: del shared.objects[vector]