Bitmessage/MiNode
3
0
Fork 1
Code Pull Requests 9 Actions Activity

Don't check for overlimit connections in test_process,

Browse Source 
leaving the buggy logic as a separate function.
This commit is contained in:
Lee Miller 2022-09-23 07:18:39 +03:00
parent 23769a8bf3
commit ae727a8327
Signed by: lee.miller
GPG Key ID: 4F97A5EA88F4AB63
1 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
minode/tests/test_process.py
View File

@ -65,6 +65,9 @@ class TestProcessShutdown(TestProcessProto):
class TestProcess(TestProcessProto): class TestProcess(TestProcessProto):
"""The test case for minode process""" """The test case for minode process"""
_wait_time = 120
_check_limit = False
def test_connections(self): def test_connections(self):
"""Check minode process connections""" """Check minode process connections"""
_started = time.time() _started = time.time()
@ -74,24 +77,30 @@ class TestProcess(TestProcessProto):
c for c in self.process.connections() c for c in self.process.connections()
if c.status == 'ESTABLISHED'] if c.status == 'ESTABLISHED']
for t in range(120): def continue_check_limit(extra_time):
for t in range(extra_time * 2):
self.assertLessEqual(
len(connections()),
# shared.outgoing_connections, one listening
# TODO: find the cause of one extra
(min(self._connection_limit, 8) if not self._listen
else self._connection_limit) + 1,
'Opened more connections than required'
' by --connection-limit')
time.sleep(1)
for t in range(self._wait_time * 2):
if len(connections()) > self._connection_limit / 2: if len(connections()) > self._connection_limit / 2:
_time_to_connect = round(time.time() - _started) _time_to_connect = round(time.time() - _started)
break break
time.sleep(0.5) time.sleep(0.5)
else: else:
self.fail( self.fail(
'Failed establish at least %s connections in 60 sec' 'Failed establish at least %s connections in %s sec'
% (self._connection_limit / 2)) % (self._connection_limit / 2, self._wait_time))
for t in range(_time_to_connect * 2):
self.assertLessEqual( if self._check_limit:
len(connections()), continue_check_limit(_time_to_connect)
# shared.outgoing_connections, one listening
# TODO: find the cause of one extra
(min(self._connection_limit, 8) if not self._listen
else self._connection_limit) + 1,
'Opened more connections than required by --connection-limit')
time.sleep(1)
for c in self.process.connections(): for c in self.process.connections():
if c.status == 'LISTEN': if c.status == 'LISTEN':