Bitmessage/MiNode
3
0
Fork 1
Code Pull Requests 7 Actions Activity

Redundant objects validation is visible for profiler #15

Merged
lee.miller merged 1 commits from lee.miller/MiNode:performance into v0.3 2024-10-23 23:56:00 +02:00
Conversation 0 Commits 1 Files Changed 1 +5 -9
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 70f059d9b1 - Show all commits

14
minode/manager.py
View File

@ -63,15 +63,11 @@ class Manager(threading.Thread):
@staticmethod @staticmethod
def clean_objects(): def clean_objects():
for vector in set(shared.objects): for vector in set(shared.objects):
if not shared.objects[vector].is_valid(): # FIXME: no need to check is_valid() here
if shared.objects[vector].is_expired(): if shared.objects[vector].is_expired():
logging.debug( logging.debug(
'Deleted expired object: %s', 'Deleted expired object: %s',
base64.b16encode(vector).decode()) base64.b16encode(vector).decode())
else:
logging.warning(
'Deleted invalid object: %s',
base64.b16encode(vector).decode())
with shared.objects_lock: with shared.objects_lock:
del shared.objects[vector] del shared.objects[vector]