From d02cde25a7442202df536569856929ab82309ecd Mon Sep 17 00:00:00 2001 From: Lee Miller Date: Tue, 2 Jul 2024 20:21:16 +0300 Subject: [PATCH 1/2] Lower timestamps in the addr message by a half of PyBitmessage ADDRESS_ALIVE --- minode/structure.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/minode/structure.py b/minode/structure.py index 53785b8..6634b5c 100644 --- a/minode/structure.py +++ b/minode/structure.py @@ -198,7 +198,7 @@ class NetAddr(): def to_bytes(self): b = b'' - b += struct.pack('>Q', int(time.time())) + b += struct.pack('>Q', int(time.time() - 5400)) b += struct.pack('>I', self.stream) b += NetAddrNoPrefix(self.services, self.host, self.port).to_bytes() return b -- 2.45.1 From df7f4bffdc43407ee3c41c8703f9b9a698833220 Mon Sep 17 00:00:00 2001 From: Lee Miller Date: Tue, 2 Jul 2024 20:29:50 +0300 Subject: [PATCH 2/2] Add a minimal sanity check for addresses in the received addr message --- minode/connection.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/minode/connection.py b/minode/connection.py index c74af5d..fe57d1e 100644 --- a/minode/connection.py +++ b/minode/connection.py @@ -425,6 +425,8 @@ class Connection(threading.Thread): addr = message.Addr.from_message(m) logging.debug('%s:%s -> %s', self.host_print, self.port, addr) for a in addr.addresses: + if not a.host or a.port == 0: + continue shared.unchecked_node_pool.add((a.host, a.port)) elif m.command == b'ping': -- 2.45.1