Strange log messages started to appear with recent code changes #1834

Open
opened 2021-08-27 15:02:26 +02:00 by g1itch · 11 comments
g1itch commented 2021-08-27 15:02:26 +02:00 (Migrated from github.com)

Hello!

With recent code I see this log message when opening any 'inbox' folder in the bitmessageqt app

2021-08-27 15:49:00,688 - WARNING - Section or Option did not found: No section: 'BM-2cXrFSw75fT5FP7qWbM86jpMTSGFBD7uLU'
2021-08-27 15:49:00,691 - WARNING - sendBroadcast didn't work
Hello! With recent code I see this log message when opening any 'inbox' folder in the `bitmessageqt` app ``` 2021-08-27 15:49:00,688 - WARNING - Section or Option did not found: No section: 'BM-2cXrFSw75fT5FP7qWbM86jpMTSGFBD7uLU' 2021-08-27 15:49:00,691 - WARNING - sendBroadcast didn't work ```
g1itch commented 2021-08-27 15:14:18 +02:00 (Migrated from github.com)

UPD: it appears without any action, probably related to sending a pubkey

UPD: it appears without any action, probably related to sending a pubkey
g1itch commented 2021-08-27 15:36:52 +02:00 (Migrated from github.com)

Introduced in 6dffb1e or earlier, I'm checking it with the appimage: https://github.com/g1itch/PyBitmessage/actions/runs/1174396926

Introduced in 6dffb1e or earlier, I'm checking it with the appimage: https://github.com/g1itch/PyBitmessage/actions/runs/1174396926
PeterSurda commented 2021-08-27 16:22:47 +02:00 (Migrated from github.com)

Check your "Sent" folder, you may have a broadcast queued for an address that is now deleted. It's only improved logging that changed, before it would also try to send a broadcast but just silently fail.

Check your "Sent" folder, you may have a broadcast queued for an address that is now deleted. It's only improved logging that changed, before it would also try to send a broadcast but just silently fail.
PeterSurda commented 2021-08-27 16:23:56 +02:00 (Migrated from github.com)

Maybe check with sqlite command line tool even, I'm not sure it would show up in "Sent" if the address has been deleted in the meantime.

Maybe check with sqlite command line tool even, I'm not sure it would show up in "Sent" if the address has been deleted in the meantime.
g1itch commented 2021-08-27 16:45:42 +02:00 (Migrated from github.com)

Good night! Found it:

sqlite> SELECT subject, message, status FROM sent WHERE fromaddress='BM-2cXrFSw75fT5FP7qWbM86jpMTSGFBD7uLU' and folder='sent';
subject|message|status
test_subject|test message|doingbroadcastpow
Good night! Found it: ``` sqlite> SELECT subject, message, status FROM sent WHERE fromaddress='BM-2cXrFSw75fT5FP7qWbM86jpMTSGFBD7uLU' and folder='sent'; subject|message|status test_subject|test message|doingbroadcastpow ```
PeterSurda commented 2021-08-27 16:59:49 +02:00 (Migrated from github.com)

The error messages now also have improved accuracy, if it says sendBroadcast didn't work, it really means sendBroadcast didn't work, rather than a pubkey or some other object. Step by step things are getting better.

The error messages now also have improved accuracy, if it says `sendBroadcast didn't work`, it really means `sendBroadcast` didn't work, rather than a pubkey or some other object. Step by step things are getting better.
g1itch commented 2021-08-28 14:58:11 +02:00 (Migrated from github.com)

Shouldn't it also report an error for these 10 broadcasts?

sqlite> SELECT count(*) FROM sent WHERE status='broadcastqueued' and folder='sent';
10
Shouldn't it also report an error for these 10 broadcasts? ``` sqlite> SELECT count(*) FROM sent WHERE status='broadcastqueued' and folder='sent'; 10 ```
g1itch commented 2021-09-01 18:13:36 +02:00 (Migrated from github.com)

Now I see many warnings about "Proof of Work exception" which are wrong, please see my comments on fc19c54

Now I see many warnings about "Proof of Work exception" which are wrong, please see my comments on fc19c54
g1itch commented 2021-09-02 15:28:00 +02:00 (Migrated from github.com)

I always suggest writing tests to avoid exactly such cases. Before editing the code you need to understand and document what it does, I think.

I always suggest writing tests to avoid exactly such cases. Before editing the code you need to understand and document what it does, I think.
g1itch commented 2021-09-02 16:53:10 +02:00 (Migrated from github.com)

You can also see it in the recent buildbot runs, e.g. https://buildbot.bitmessage.org/#/builders/25/builds/2180/steps/8/logs/stdio, line 852.

This is the effect of missing return: https://buildbot.bitmessage.org/#/builders/25/builds/2220/steps/8/logs/stdio, line 846

You can also see it in the recent buildbot runs, e.g. https://buildbot.bitmessage.org/#/builders/25/builds/2180/steps/8/logs/stdio, line 852. This is the effect of missing return: https://buildbot.bitmessage.org/#/builders/25/builds/2220/steps/8/logs/stdio, line 846
g1itch commented 2021-09-29 16:02:49 +02:00 (Migrated from github.com)

This one is also started to appear lately:

WARNING - (Within the processgetpubkey function) Someone requested one of my pubkeys but the requestedAddressVersionNumber doesn't match my actual address version number. Ignoring.

And the "Proof of Work exception" right after it.

This one is also started to appear lately: ``` WARNING - (Within the processgetpubkey function) Someone requested one of my pubkeys but the requestedAddressVersionNumber doesn't match my actual address version number. Ignoring. ``` And the "Proof of Work exception" right after it.
This repo is archived. You cannot comment on issues.
No Milestone
No project
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-08-21#1834
No description provided.