Bitmessage/PyBitmessage-2024-08-21
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Fixes issue #691 #701

Merged
bmng-dev merged 1 commits from Issue-#691 into master 2014-08-06 23:25:40 +02:00
Conversation 2 Commits 1 Files Changed 5 +86 -98
bmng-dev commented 2014-08-06 06:53:06 +02:00 (Migrated from github.com)
Copy Link

This fixes the encoding issues around datetime formatting. It introduces a new module l10n that aims to make localization a little easier. If the language and/or encoding can not be determined it defaults to en_US and ISO8859-1. The use of ISO8859-1 prevents decoding errors, but may result in foreign or wrong characters being displayed when locale formatting options are used.
At the moment it offers formatTimestamp and getTranslationLanguage functions:
formatTimestamp returns the provided timestamp (or current time if ommitted or the wrong type) as unicode (default) or raw bytestring.
getTranslationLanguage simply returns the users language. It is the result of refactoring the QtTranslator initialization for the Qt GUI.

Resolves #691

This fixes the encoding issues around datetime formatting. It introduces a new module l10n that aims to make localization a little easier. If the language and/or encoding can not be determined it defaults to en_US and ISO8859-1. The use of ISO8859-1 prevents decoding errors, but may result in foreign or wrong characters being displayed when locale formatting options are used. At the moment it offers formatTimestamp and getTranslationLanguage functions: formatTimestamp returns the provided timestamp (or current time if ommitted or the wrong type) as unicode (default) or raw bytestring. getTranslationLanguage simply returns the users language. It is the result of refactoring the QtTranslator initialization for the Qt GUI. Resolves #691
Atheros1 commented 2014-08-06 23:54:25 +02:00 (Migrated from github.com)
Copy Link

Thank you bmng. This is quite a complex one!

Thank you bmng. This is quite a complex one!
Atheros1 commented 2014-08-07 17:22:34 +02:00 (Migrated from github.com)
Copy Link

bmng, A user has reported a problem with this pull request:
https://pay.reddit.com/r/bitmessage/comments/2cttc4/new_bitmessage_version_v043/cjjf28f

bmng, A user has reported a problem with this pull request: https://pay.reddit.com/r/bitmessage/comments/2cttc4/new_bitmessage_version_v043/cjjf28f
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-08-21#701
No description provided.
Delete Branch "Issue-#691"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?