replace print statements with logger #1688

Closed
navjotcis wants to merge 2 commits from bug-fixes14 into v0.6
3 changed files with 49 additions and 40 deletions
Showing only changes of commit f67ffad69d - Show all commits

View File

@ -1,7 +1,6 @@
""" """
Track randomize ordered dict Track randomize ordered dict
""" """
import random
from threading import RLock from threading import RLock
from time import time from time import time
@ -128,41 +127,3 @@ class RandomTrackingDict(object):
self.pendingLen += 1 self.pendingLen += 1
self.lastPoll = time() self.lastPoll = time()
return retval return retval
if __name__ == '__main__':
# pylint: disable=redefined-outer-name
def randString():
"""helper function for tests, generates a random string"""
retval = b''
for _ in range(32):
retval += chr(random.randint(0, 255))
return retval
a = []
k = RandomTrackingDict()
d = {}
print "populating random tracking dict"
a.append(time())
for i in range(50000):
k[randString()] = True
a.append(time())
print "done"
while k:
retval = k.randomKeys(1000)
if not retval:
print "error getting random keys"
try:
k.randomKeys(100)
print "bad"
except KeyError:
pass
for i in retval:
del k[i]
a.append(time())
for x in range(len(a) - 1):
print "%i: %.3f" % (x, a[x + 1] - a[x])

View File

@ -4,6 +4,7 @@ Module for using filesystem (directory with files) for inventory storage
import string import string
import time import time
from binascii import hexlify, unhexlify from binascii import hexlify, unhexlify
from debug import logger
from os import listdir, makedirs, path, remove, rmdir from os import listdir, makedirs, path, remove, rmdir
from threading import RLock from threading import RLock
@ -162,7 +163,7 @@ class FilesystemInventory(InventoryStorage):
newInventory[streamNumber][hashId] = InventoryItem( newInventory[streamNumber][hashId] = InventoryItem(
objectType, streamNumber, None, expiresTime, tag) objectType, streamNumber, None, expiresTime, tag)
except KeyError: except KeyError:
print "error loading %s" % (hexlify(hashId)) logger.warning('error loading %s', hexlify(hashId))
self._inventory = newInventory self._inventory = newInventory
# for i, v in self._inventory.items(): # for i, v in self._inventory.items():
# print "loaded stream: %s, %i items" % (i, len(v)) # print "loaded stream: %s, %i items" % (i, len(v))

View File

@ -0,0 +1,47 @@
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
"""
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
Tests for RandomTrackingDict class
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
"""
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
import random
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
import unittest
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
from network import randomtrackingdict
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
from time import time
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
class TestRandomTrackingDict(unittest.TestCase):
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
"""Main protocol test case"""
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
@staticmethod
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
def randString():
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
"""helper function for tests, generates a random string"""
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
retval = b''
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
for _ in range(32):
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
retval += chr(random.randint(0, 255))
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
return retval
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
def test_check_randomtrackingdict(self):
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
"""Check the logic of RandomTrackingDict class"""
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
a = []
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
k = randomtrackingdict.RandomTrackingDict()
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
a.append(time())
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
for i in range(50000):
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
k[self.randString()] = True
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
a.append(time())
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
while k:
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
retval = k.randomKeys(1000)
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
if not retval:
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
self.fail("error getting random keys")
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
try:
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
k.randomKeys(100)
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
self.fail("bad")
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
except KeyError:
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
pass
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
for i in retval:
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
del k[i]
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
a.append(time())
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
for x in range(len(a) - 1):
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
self.assertLess(a[x + 1] - a[x], 10)
PeterSurda commented 2020-12-19 19:55:09 +01:00 (Migrated from github.com)
Review

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda commented 2020-12-19 19:55:50 +01:00 (Migrated from github.com)
Review

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda commented 2020-12-19 20:00:50 +01:00 (Migrated from github.com)
Review

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-22 09:10:02 +01:00 (Migrated from github.com)
Review

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda commented 2020-12-22 09:10:41 +01:00 (Migrated from github.com)
Review

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.