Test cases for shared.py #2201

Merged
anand-skss merged 1 commits from test_case into v0.6 2024-04-18 04:39:46 +02:00

152
src/tests/test_shared.py Normal file
View File

@ -0,0 +1,152 @@
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"""Test cases for shared.py"""
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
import unittest
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
from pybitmessage.shared import (
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
isAddressInMyAddressBook,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
isAddressInMySubscriptionsList,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
checkSensitiveFilePermissions,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
reloadBroadcastSendersForWhichImWatching,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
fixSensitiveFilePermissions,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
MyECSubscriptionCryptorObjects,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
stat,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
os,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
from .samples import sample_address
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
try:
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# Python 3
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
from unittest.mock import patch, PropertyMock
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
except ImportError:
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# Python 2
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
from mock import patch, PropertyMock
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# mock os.stat data for file
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PERMISSION_MODE1 = stat.S_IRUSR # allow Read permission for the file owner.
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PERMISSION_MODE2 = (
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
stat.S_IRWXO
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
) # allow read, write, serach & execute permission for other users
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
INODE = 753
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
DEV = 1795
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
NLINK = 1
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
UID = 1000
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
GID = 0
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
SIZE = 1021
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
ATIME = 1711587560
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
MTIME = 1709449249
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
CTIME = 1709449603
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
class TestShared(unittest.TestCase):
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"""Test class for shared.py"""
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
@patch("pybitmessage.shared.sqlQuery")
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
def test_isaddress_in_myaddressbook(self, mock_sql_query):
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"""Test if address is in MyAddressbook"""
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
address = sample_address
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# if address is in MyAddressbook
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_sql_query.return_value = [address]
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
return_val = isAddressInMyAddressBook(address)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_sql_query.assert_called_once()
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertTrue(return_val)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# if address is not in MyAddressbook
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_sql_query.return_value = []
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
return_val = isAddressInMyAddressBook(address)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertFalse(return_val)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertEqual(mock_sql_query.call_count, 2)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
@patch("pybitmessage.shared.sqlQuery")
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
def test_isaddress_in_mysubscriptionslist(self, mock_sql_query):
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"""Test if address is in MySubscriptionsList"""
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
address = sample_address
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# if address is in MySubscriptionsList
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_sql_query.return_value = [address]
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
return_val = isAddressInMySubscriptionsList(address)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertTrue(return_val)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# if address is not in MySubscriptionsList
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_sql_query.return_value = []
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
return_val = isAddressInMySubscriptionsList(address)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertFalse(return_val)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertEqual(mock_sql_query.call_count, 2)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
@patch("pybitmessage.shared.sqlQuery")
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
def test_reloadBroadcastSendersForWhichImWatching(self, mock_sql_query):
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"""Test for reload Broadcast Senders For Which Im Watching"""
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_sql_query.return_value = [
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
(sample_address,),
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
]
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# before reload
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertEqual(len(MyECSubscriptionCryptorObjects), 0)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# reloading with addressVersionNumber 1
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
reloadBroadcastSendersForWhichImWatching()
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertGreater(len(MyECSubscriptionCryptorObjects), 0)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
@patch("pybitmessage.shared.os.stat")
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
@patch(
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"pybitmessage.shared.sys",
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
new_callable=PropertyMock, # pylint: disable=used-before-assignment
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
def test_check_sensitive_file_permissions(self, mock_sys, mock_os_stat):
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"""Test to check file permissions"""
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
fake_filename = "path/to/file"
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# test for windows system
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_sys.platform = "win32"
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
result = checkSensitiveFilePermissions(fake_filename)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertTrue(result)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# test for freebsd system
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_sys.platform = "freebsd7"
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# returning file permission mode stat.S_IRUSR
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
MOCK_OS_STAT_RETURN = os.stat_result(
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
sequence=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9],
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
dict={
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_mode": PERMISSION_MODE1,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_ino": INODE,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_dev": DEV,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_nlink": NLINK,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_uid": UID,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_gid": GID,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_size": SIZE,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_atime": ATIME,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_mtime": MTIME,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_ctime": CTIME,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
},
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_os_stat.return_value = MOCK_OS_STAT_RETURN
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
result = checkSensitiveFilePermissions(fake_filename)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self.assertTrue(result)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
@patch("pybitmessage.shared.os.chmod")
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
@patch("pybitmessage.shared.os.stat")
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
def test_fix_sensitive_file_permissions( # pylint: disable=no-self-use
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
self, mock_os_stat, mock_chmod
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
):
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"""Test to fix file permissions"""
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
fake_filename = "path/to/file"
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
# returning file permission mode stat.S_IRWXO
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
MOCK_OS_STAT_RETURN = os.stat_result(
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
sequence=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9],
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
dict={
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_mode": PERMISSION_MODE2,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_ino": INODE,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_dev": DEV,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_nlink": NLINK,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_uid": UID,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_gid": GID,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_size": SIZE,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_atime": ATIME,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_mtime": MTIME,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
"st_ctime": CTIME,
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
},
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_os_stat.return_value = MOCK_OS_STAT_RETURN
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
fixSensitiveFilePermissions(fake_filename, False)
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants
mock_chmod.assert_called_once()
PeterSurda commented 2024-04-05 01:05:10 +02:00 (Migrated from github.com)
Review

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda commented 2024-04-13 15:18:56 +02:00 (Migrated from github.com)
Review

maybe use addresses from samples

maybe use addresses from samples
PeterSurda commented 2024-04-13 15:20:11 +02:00 (Migrated from github.com)
Review

use constants

use constants
anand-skss commented 2024-04-15 04:43:55 +02:00 (Migrated from github.com)
Review

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda commented 2024-04-16 06:16:37 +02:00 (Migrated from github.com)
Review

I mean the numbers should be constants

I mean the numbers should be constants