Refactor type 2 message decoding, drop any extra lines from subject. #295

2013-07-12T12:21:31+02:00

grbitmsg commented

2013-07-12 12:21:31 +02:00

(Migrated from github.com)

This allows other clients to insert headers in extra lines of text between
the Subject and Body fields of the message, as discussed on the 24x7 mailing
list. The PyBitmessage client was never able to meaningfully display
multi-line subjects, so this does not break anything. The extra lines are
thrown away and never stored anywhere, so this also protects against
watermarking attacks.

This allows other clients to insert headers in extra lines of text between the Subject and Body fields of the message, as discussed on the 24x7 mailing list. The PyBitmessage client was never able to meaningfully display multi-line subjects, so this does not break anything. The extra lines are thrown away and never stored anywhere, so this also protects against watermarking attacks.

Atheros1 commented

2013-07-14 22:40:03 +02:00

(Migrated from github.com)

Looks Good. Thank you.

This repo is archived. You cannot comment on pull requests.

No reviewers