Total setup.py cleanup and simple script installation #957

Merged
g1itch merged 1 commits from setuptools-minimal into v0.6 2017-02-28 19:03:50 +01:00
g1itch commented 2017-02-28 12:17:49 +01:00 (Migrated from github.com)

Hello!

I made some changes to setuptools settings trying to make the it's operations more predictable, particularly:

  • the package pybitmessage installed into pybitmessage directory;
  • distutils-style script installation (a bit tricky): commented setuptools entry point could work if the program were able to run inside package, but currently it will lead to namespace problems and circular dependencies;
  • MANIFEST.in lists the files needed for sdist command (appended working files which may appear after it's invocation to .gitignore );

I also

  • made setup.py clean, readable and strict PEP8;
  • fixed typo in certificates location -> 'sslkeys/*.pem';
  • added the package manager and packages names for gentoo (Calculate is it's flavor).
Hello! I made some changes to setuptools settings trying to make the it's operations more predictable, particularly: * the package `pybitmessage` installed into `pybitmessage` directory; * distutils-style script installation (a bit tricky): commented setuptools entry point could work if the program were able to run inside package, but currently it will lead to namespace problems and circular dependencies; * MANIFEST.in lists the files needed for `sdist` command (appended working files which may appear after it's invocation to `.gitignore` ); I also * made `setup.py` clean, readable and strict PEP8; * fixed typo in certificates location -> 'sslkeys/*.pem'; * added the package manager and packages names for gentoo (Calculate is it's flavor).
PeterSurda commented 2017-02-28 12:24:20 +01:00 (Migrated from github.com)

Thanks, can you rebase it please so that I can do a fast forward merge? I'll do tests but I'm really happy about the fixes and would like to merge it right away.

Thanks, can you rebase it please so that I can do a fast forward merge? I'll do tests but I'm really happy about the fixes and would like to merge it right away.
g1itch commented 2017-02-28 12:53:23 +01:00 (Migrated from github.com)

I thought I've done with rebase but now I cannot change the branch in pull request ): to g1itch:v0.6.

I thought I've done with rebase but now I cannot change the branch in pull request ): to g1itch:v0.6.
g1itch commented 2017-02-28 15:04:28 +01:00 (Migrated from github.com)

Finally I did push -f. Hope it's on right place now.

Finally I did `push -f`. Hope it's on right place now.
PeterSurda commented 2017-02-28 17:43:42 +01:00 (Migrated from github.com)

I cannot find your PGP pubkey. I don't see a way to download it from github, it's not on the keyserver network.

I cannot find your PGP pubkey. I don't see a way to download it from github, it's not on the keyserver network.
PeterSurda commented 2017-02-28 19:04:05 +01:00 (Migrated from github.com)

Please upload the key some time in the future.

Please upload the key some time in the future.
g1itch commented 2017-03-01 09:49:37 +01:00 (Migrated from github.com)

I've published it yesterday on pgp.mit.edu.

I've published it yesterday on pgp.mit.edu.
PeterSurda commented 2017-03-01 09:52:43 +01:00 (Migrated from github.com)

ok got it now.

ok got it now.
This repo is archived. You cannot comment on pull requests.
No description provided.