Label unicode bug #1194

New Issue

2018-03-30T14:55:24+02:00

PeterSurda commented

2018-03-30 14:55:24 +02:00

(Migrated from github.com)

Arrived in bitmessage chan.

Got to Messages tab, double click address, enter name/label/alias:

Traceback (most recent call last):
File
"/usr/local/lib/python2.7/dist-packages/pybitmessage/bitmessageqt/foldertree.py",
line 237, in setData
if isinstance(value, QtCore.QVariant) else str(value)
AttributeError: 'str' object has no attribute 'toString'

diff --git a/src/bitmessageqt/foldertree.py
b/src/bitmessageqt/foldertree.py
index f3ac38d..48c32eb 100644
--- a/src/bitmessageqt/foldertree.py
+++ b/src/bitmessageqt/foldertree.py
@@ -233,7 +233,7 @@ class Ui_AddressWidget(BMTreeWidgetItem,
SettingsMixin):
and self.type != AccountMixin.SUBSCRIPTION:
BMConfigParser().set(
str(self.address), 'label',
           str(value).toString().toUtf8()
           str(value.toString().toUtf8())
           if isinstance(value, QtCore.QVariant) else
str(value)
)
BMConfigParser().save()

Not sure what you mean by aliases.

Peter Surda
Bitmessage core developer

Hello, I can't seem to give aliases to any address of mine anymore.

Using latest Pybitmessage from v0.6 branch.

Arrived in bitmessage chan. > Got to Messages tab, double click address, enter name/label/alias: > > Traceback (most recent call last): > File > "/usr/local/lib/python2.7/dist-packages/pybitmessage/bitmessageqt/foldertree.py", > line 237, in setData > if isinstance(value, QtCore.QVariant) else str(value) > AttributeError: 'str' object has no attribute 'toString' > > > diff --git a/src/bitmessageqt/foldertree.py > b/src/bitmessageqt/foldertree.py > index f3ac38d..48c32eb 100644 > --- a/src/bitmessageqt/foldertree.py > +++ b/src/bitmessageqt/foldertree.py > @@ -233,7 +233,7 @@ class Ui_AddressWidget(BMTreeWidgetItem, > SettingsMixin): > and self.type != AccountMixin.SUBSCRIPTION: > BMConfigParser().set( > str(self.address), 'label', > - str(value).toString().toUtf8() > + str(value.toString().toUtf8()) > if isinstance(value, QtCore.QVariant) else > str(value) > ) > BMConfigParser().save() > > > ------------------------------------------------------ > Not sure what you mean by aliases. > > Peter Surda > Bitmessage core developer > > > Hello, I can't seem to give aliases to any address of mine anymore. > > > > Using latest Pybitmessage from v0.6 branch. >

PeterSurda commented

2018-04-02 17:58:11 +02:00

(Migrated from github.com)

Can now reproduce it. Renaming chan name is broken.

PeterSurda commented

2018-04-03 14:58:43 +02:00

(Migrated from github.com)

Fixed in 6eb2155497

Fixed in 6eb2155497891344b4f6c7d1ce5992f748044876

This repo is archived. You cannot comment on issues.