Bitmessage/PyBitmessage-2024-11-30
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Creation of a setup.py #950

Closed
Lvl4Sword wants to merge 2 commits from patch-1 into v0.6
pull from: patch-1
merge into: Bitmessage:v0.6
Conversation 5 Commits 2 Files Changed 1 +50
Lvl4Sword commented 2017-02-23 11:21:30 +01:00 (Migrated from github.com)
Copy Link
No description provided.
PeterSurda (Migrated from github.com) reviewed 2017-02-23 11:21:30 +01:00
PeterSurda commented 2017-02-23 22:39:48 +01:00 (Migrated from github.com)
Copy Link

I had to merge the language first, please rebase/resign. It's a good start so I'll merge it and give you a tip, but it's not adequate, I'm working on an improved version and commit that on top of your commit. Some of the dependencies (hashlib) are part of python, some (pyqt) aren't supported by setuptools and so on. But I got it mostly working.

I had to merge the language first, please rebase/resign. It's a good start so I'll merge it and give you a tip, but it's not adequate, I'm working on an improved version and commit that on top of your commit. Some of the dependencies (hashlib) are part of python, some (pyqt) aren't supported by setuptools and so on. But I got it mostly working.
PeterSurda commented 2017-02-24 02:08:51 +01:00 (Migrated from github.com)
Copy Link

Ok I got it working. Please rebase/resign within a day, otherwise I won't have time to delay my commit.

Ok I got it working. Please rebase/resign within a day, otherwise I won't have time to delay my commit.
g1itch commented 2017-02-24 10:27:42 +01:00 (Migrated from github.com)
Copy Link

You probably forgot a dependency on pygobject and numpy.

You probably forgot a dependency on pygobject and numpy.
g1itch (Migrated from github.com) reviewed 2017-02-24 15:27:28 +01:00
setup.py
@ -0,0 +40,4 @@
"Programming Language :: Python :: 2.7.12",
"Programming Language :: Python :: 2.7.13",
],
packages=find_packages(include=['src'])
g1itch (Migrated from github.com) commented 2017-02-24 15:27:28 +01:00

missing coma
and also this installs package 'src'

missing coma and also this installs package 'src'
PeterSurda commented 2017-02-24 23:49:45 +01:00 (Migrated from github.com)
Copy Link

I committed my own, more advanced, version then.

I committed my own, more advanced, version then.
g1itch commented 2017-03-06 11:48:21 +01:00 (Migrated from github.com)
Copy Link

Maybe you can close also #171

Maybe you can close also #171
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.6.2
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-11-30#950
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?