Refactored some table items to remove the universal unreadable variable ... #547

2013-11-05T22:37:44+01:00

neko259 commented

2013-11-05 22:37:44 +01:00

(Migrated from github.com)

Removed one use of the variable 'new_item' that is used for completely different items and makes the code unreadable. Going to do the same for other tables and split their code to methods and classes to get rid of the horrible MyForm god object.

neko259 commented

2013-11-05 22:44:27 +01:00

(Migrated from github.com)

If you already have a refactoring plan, please provide it so that I won't interfere and break your planned design. My main goal is to split everything into small pieces so that a developer could at least understand what is done in some place and where to find the piece he needs to change.

Atheros1 commented

2013-11-06 04:05:43 +01:00

(Migrated from github.com)

I plan on reworking the part of the code which process messages but I have no plans to touch the UI code currently except for a pending pull request to add a settings option to quit resending message after a period of time.

neko259 commented

2013-11-06 07:14:59 +01:00

(Migrated from github.com)

Ok than :)

Atheros1 commented

2013-11-07 20:08:37 +01:00

(Migrated from github.com)

Excellent so far. Thank you.

This repo is archived. You cannot comment on pull requests.

No reviewers