Bitmessage/PyBitmessage-2024-12-02
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Randomise key order during decryption

Browse Source 
- may help against timing/radio attacks
This commit is contained in:
Peter Šurda 2017-11-30 20:08:14 +01:00
parent 6c224447a6
commit 4ee9d05446
Signed by: PeterSurda
GPG Key ID: 0C5F50C0B5F37D87
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/class_objectProcessor.py
View File

@ -361,7 +361,7 @@ class objectProcessor(threading.Thread):
# This is not an acknowledgement bound for me. See if it is a message # This is not an acknowledgement bound for me. See if it is a message
# bound for me by trying to decrypt it with my private keys. # bound for me by trying to decrypt it with my private keys.
for key, cryptorObject in shared.myECCryptorObjects.items(): for key, cryptorObject in sorted(shared.myECCryptorObjects.items(), key=lambda x: random.random()):
try: try:
if initialDecryptionSuccessful: # continue decryption attempts to avoid timing attacks if initialDecryptionSuccessful: # continue decryption attempts to avoid timing attacks
cryptorObject.decrypt(data[readPosition:]) cryptorObject.decrypt(data[readPosition:])
@ -634,7 +634,7 @@ class objectProcessor(threading.Thread):
""" """
signedData = data[8:readPosition] signedData = data[8:readPosition]
initialDecryptionSuccessful = False initialDecryptionSuccessful = False
for key, cryptorObject in shared.MyECSubscriptionCryptorObjects.items(): for key, cryptorObject in sorted(shared.MyECSubscriptionCryptorObjects.items(), key=lambda x: random.random()):
try: try:
if initialDecryptionSuccessful: # continue decryption attempts to avoid timing attacks if initialDecryptionSuccessful: # continue decryption attempts to avoid timing attacks
cryptorObject.decrypt(data[readPosition:]) cryptorObject.decrypt(data[readPosition:])