getpubkey length handling

- don't try to process getpubkey that is too long
2017-04-04 10:44:53 +02:00 · 2017-04-04 10:44:53 +02:00 · fe93473fc5
commit fe93473fc5
parent c1bdcc2aba
2 changed files with 3 additions and 2 deletions
--- a/src/class_objectProcessor.py
+++ b/src/class_objectProcessor.py
@ -106,6 +106,9 @@ class objectProcessor(threading.Thread):

    
    def processgetpubkey(self, data):
+        if len(data) > 200:
+            logger.info('getpubkey is abnormally long. Sanity check failed. Ignoring object.')
+            return
        readPosition = 20  # bypass the nonce, time, and object type
        requestedAddressVersionNumber, addressVersionLength = decodeVarint(
            data[readPosition:readPosition + 10])
--- a/src/shared.py
+++ b/src/shared.py
@ -432,8 +432,6 @@ def _checkAndShareGetpubkeyWithPeers(data):
    if len(data) < 42:
        logger.info('getpubkey message doesn\'t contain enough data. Ignoring.')
        return
-    if len(data) > 200:
-        logger.info('getpubkey is abnormally long. Sanity check failed. Ignoring object.')
    embeddedTime, = unpack('>Q', data[8:16])
    readPosition = 20  # bypass the nonce, time, and object type
    requestedAddressVersionNumber, addressVersionLength = decodeVarint(