Commit Graph

864 Commits

Author SHA1 Message Date
coffeedogs
e5e9f70c2a
Fixed: Code style and lint issues 2018-06-15 12:54:41 +01:00
coffeedogs
d9f0a8708b
Fixed: Chan-provided diff to revert changes from boolean operators to any()/all(). Closes #1277. 2018-06-15 12:25:10 +01:00
coffeedogs
6f5c261fb4
Merge branch 'v0.6' into codeQ-2805 2018-06-12 00:24:48 +01:00
coffeedogs
759b760977
Fixed: Style and lint violations for three more of the worst violating files 2018-05-28 14:35:30 +01:00
coffeedogs
9263026bc8
Fixed: Addressed issues raised in PR 2018-05-17 10:51:21 +01:00
coffeedogs
da87ae24ee
Fixed: Style and lint violations in src/bitmessageqt/__init__.py 2018-05-15 16:20:53 +01:00
6eb2155497
Another unicode -> str bug (#1194) 2018-04-03 15:11:46 +03:00
2268413cd0
Do not try to connect namecoin if dontconnect set in config (#1146) 2018-03-26 16:47:22 +03:00
d7ac440a04
Merge branch '1172' into upstream-v0.6 2018-03-22 16:12:53 +01:00
9ccd3a0989
Prevent settingsDialog from setting dontconnect = false
if "Work offline" was checked in the ConnectDialog
2018-03-22 17:10:29 +02:00
6cefaf87e9
Module foldertree: changed subclassing order to reuse common code 2018-03-22 14:55:30 +02:00
90eca36b5d
Module foldertree: simplified a bit and did flake8 2018-03-22 14:55:25 +02:00
72299483c4
Do not duplicate avatar in address column of Address book 2018-03-14 16:34:03 +02:00
3850a920c9
Do not add gui.menu plugins with prefix 'address' to "All accounts" item 2018-03-13 13:46:47 +02:00
08a2115412
Properly renamed qrcode plugin module and made menu available
for all address entries except for addressbook and blacklist
2018-03-13 13:46:47 +02:00
1e4400a207
Remove obsolete code
- PendingDownload and PendingUpload in inventory.py are obsolete
- the replacement functions only provide lengths and are in
  network/stats.py
2018-03-13 07:32:23 +01:00
616920e21a
Minor UI fixes
- typo in UTF conversion
- update status message correct matching (does not show all messages as
changed status, for example)
- add newly sent messages to global sent folder if selected
2018-02-18 19:39:26 +01:00
a3436fef9c
Quick fix for refactoring artifact in blacklist module (#1138) 2018-02-17 14:36:09 +02:00
c050ef0814
Messagetype attack mitigation
- temporarily restrict messagetypes
- use a new "Contact support" address
2018-02-13 23:33:12 +01:00
6bcbad63b9
Marked folder names for translation 2018-02-12 21:10:10 +02:00
2bc2b6bc5b
Typo 2018-02-12 14:49:43 +01:00
eefc967737
Pluralisation 2018-02-12 14:10:51 +01:00
a69daa13b9
Pluralisation 2018-02-12 13:48:59 +01:00
cf8ed36240
Windows Qt refactoring fix 2018-02-09 11:11:48 +01:00
066b419e16
Bugfixes
- typo in dandelion
- stealth ackdata fix for broadcasts and mailing lists
2018-02-09 00:49:08 +01:00
bbb5e5d99b
Fixed trailing '>' in message view which appeared after HTLM rendering 2018-02-08 12:58:38 +02:00
f870bcc6f7
More lightweight URI regexp
- the old one can take a lot of resources and be misused for a DoS
- this still nees to be tested if it is flexible enough
- also fix link click popup
2018-02-08 06:52:33 +01:00
c6834093ee
QT sqlite conversion fix
- QByteArray will be stored as str in the db
2018-02-06 23:55:41 +01:00
d083c53e1b
New button "Clear" on tab "Send" to clear all fields (#919) 2018-02-06 21:07:01 +02:00
6269e45a47
Merge branch '1117' into v0.6 2018-02-06 18:21:33 +01:00
3b3e4de9d7
Zero Inventory().numberOfInventoryLookupsPerformed before update started
because "Inventory lookups per second" is calculated by /2 (for 2 sec)
2018-02-06 17:33:19 +02:00
4a3f8f4806
Change unread status of message in "All Accounts"
when it changed in "Chans" and vice versa (#1044, #884)
2018-02-06 15:48:56 +02:00
85cce42de0
Update "Network Status" information only when the tab selected 2018-02-05 14:39:32 +02:00
ec30472dd8
AboutDialog formatting fix (hope) 2018-02-02 18:31:53 +02:00
b0271e51ff
Set fixed size for simple dialogs 2018-02-02 18:31:07 +02:00
25a9e5ea45
Fixed errors I introduced in commit 4115540 after rebase 2018-01-31 20:12:04 +02:00
9807d3e4b4
Don't complain about being disconnected if in offline mode 2018-01-30 17:42:10 +01:00
c92c2aebc2
Blank title of RegenerateAddressesDialog also 2018-01-30 17:27:01 +02:00
afcd83a434
This is probably the right way to handle modal dialogs 2018-01-30 17:27:01 +02:00
41155406d6
Simplified showing statusbar messages:
- Use MyForm.statusbar set in __init__ instead of MyForm.statusBar()
 - MyForm.updateStatusBar() to show the message in MyForm methods
 - queues.UISignalQueue.put(('updateStatusBar', msg)) in dialogs
2018-01-30 17:27:01 +02:00
ece5ad9113
Separated dialogs which deal with addresses into address_dialogs module 2018-01-30 17:27:00 +02:00
c699f6d872
Got rid of wildcard imports in bitmessageqt.__init__ 2018-01-30 17:27:00 +02:00
641db73614
Removed unused _encoding and _transalate 2018-01-30 17:27:00 +02:00
25876ded2b
Removed unused import of inventory.Inventory 2018-01-30 17:27:00 +02:00
cd88d063a1
Imported NewChanDialog into dialogs module 2018-01-30 17:26:59 +02:00
35a11c271a
Moved NewAddressDialog into dialogs module 2018-01-30 17:26:59 +02:00
8109fa7ece
Moved EmailGatewayDialog (with both usage) into dialogs module 2018-01-30 17:26:59 +02:00
fe76d230eb
Moved RegenerateAddressesDialog into dialogs module 2018-01-30 17:26:58 +02:00
b899086d91
Followed the recommendation #527 about tab indexes 2018-01-30 17:26:58 +02:00
20288d4ab4
Try to replace copyright year from last commit date 2018-01-30 17:26:58 +02:00
b9cd571d9b
Hide redundant QGroupBox title 2018-01-30 17:26:58 +02:00
f3808212b5
Added link to github into labelVersion in AboutDialog 2018-01-30 17:26:57 +02:00
62a930c374
Moved SpecialAddressBehaviorDialog into dialogs module 2018-01-30 17:26:57 +02:00
c965a1d2aa
Moved helpDialog and connectDialog also into dialogs module 2018-01-30 17:26:51 +02:00
e2e7e16ab7
Moved aboutDialog and iconGlossaryDialog also into dialogs module 2018-01-30 17:26:42 +02:00
d9d9f9d787
Returned AddAddressDialog and NewSubscriptionDialog into dialogs module
where it's been initialized by loading the ui-files.
2018-01-30 16:59:51 +02:00
81c80aa98f
Use AddAddressDialog for "Add sender to your Addres Book" context menu 2018-01-30 16:59:51 +02:00
25ef9fec51
Added menu entry "File -> Go offline/Go online" switching dontconnect
config variable and "Work offline" option to connectDialog.
2018-01-30 14:04:03 +02:00
cc63c1270b
Fix message content display after deleting/undeleting 2018-01-28 16:13:07 +01:00
aabce6bab2
Fix selection after delete/undelete 2018-01-28 12:48:25 +01:00
08ac8a077b
Merge branch '1062' into v0.6 2018-01-28 10:41:09 +01:00
ff92cc30c8
Fix previous commit (UI deleting optimisation) 2018-01-28 09:16:37 +01:00
0f61ed9f19
Optimise UI deleting and undeleting multiple messages
- use sqlExecuteChunked and disable UI updates while removing entries
2018-01-28 08:12:46 +01:00
6fca1631af
Made use of helper_sql.sqlExecuteChunked() also in on_action_InboxMarkUnread 2018-01-25 23:22:15 +02:00
80fdb08f03
Made use of helper_sql.sqlExecuteChunked() in the on_action_MarkAllRead 2018-01-25 23:04:38 +02:00
0097ea6476
The condition which is always False causes critical error #1081 2018-01-25 14:29:25 +02:00
1864762a0a
Apply bandwidth limits without restart
- also minor style fixes
2018-01-01 12:49:08 +01:00
3b86dfc639
Log missing indicator plugin 2017-12-02 00:45:01 +01:00
6c224447a6
Minor fixes that came over BM
- typo in quit confirmation dialog
- nicer traceback in unhandled exceptions
2017-11-30 19:44:03 +01:00
e17d33cd75
Respect user selected sort order on "Network Status" tab 2017-10-24 14:02:15 +03:00
8fcdf51e57
One more unicode related exception - when editing a contact label 2017-10-19 18:43:41 +03:00
453bcdbb1d
Typo in newchandialog 2017-10-19 08:39:30 +02:00
a013814c6b
Network tab updates
- handle add/remove entry instead of recreating the whole connection
list
- update processed object counts after each object
2017-10-19 08:39:09 +02:00
1ba1f02686
Remove superfluous validator signal connect in newchandialog
- apparently it connects automatically and just creates an error message
2017-10-19 08:31:05 +02:00
9cffd50de8
Fixed statusbar message on error in namecoin name search 2017-10-17 11:37:50 +03:00
59d1309a9e
Fixed typo when closing tempfile in bitmessageqt.__init__ 2017-10-17 11:25:33 +03:00
9dae77dd2b
Quiet Mode (i.e. turn off notification) in tray menu 2017-10-16 19:30:12 +03:00
1abdc14807
Fix statusbar chan creation message:
non-ASCII characters displayed incorrectly
2017-10-03 18:01:54 +03:00
f97ada87
be0e724b23
implement stealth ack objects 2017-09-30 19:45:40 +10:00
4f75dcb9be
Merge pull request '1047' into v0.6
- notifications moved into plugins
- improvements in setup.py
- remove obsolete imports
2017-09-21 13:30:53 +02:00
2504bc6670
Fixed fetch of connected hosts number in bitmessageqt.support 2017-09-21 13:59:43 +03:00
1f47a4060e
Added "Set notification sound..." context menu on addressbook entry. 2017-09-20 10:21:27 +03:00
c8a47b988f
Moved "Ubuntu" MessagingMenu code into indicator_libmessaging plugin 2017-09-20 10:21:27 +03:00
cd81718871
Moved sound category constants to the separate module sound
for importing from the sound theme plugins.
2017-09-20 10:21:27 +03:00
289a6c5bfa
Added support for sound notification plugins which use
the desktop sound theme, with pycanberra for example. Plugin name should
start with 'theme' in that case, whereas the name of plugins playing the
sound file starts with 'file'.
2017-09-20 10:21:27 +03:00
be716bf228
Improved and documented plugin module 2017-09-20 10:21:27 +03:00
ef8f40ccc4
Moved notifications to plugins (including sound) 2017-09-20 10:21:27 +03:00
7e35ea6bdf
Email gateway autoregistration fixes
- don't treat "@" in label as an email address
- ask for confirmation before autoregistering. It confused some
newbies into thinking that bitmessage requires payment
2017-08-24 14:16:37 +02:00
2da4d00730
Support message C PoW fix 2017-08-15 18:14:36 +02:00
a2b8867c1a
Tooltips for network status columns 2017-07-06 19:36:04 +02:00
a0bbd21efc
Add ratings to peers
- outbound peers now have a rating
- it's also shown in the network status tab
- currently it's between -1 to +1, changes by 0.1 steps and uses a
hyperbolic function 0.05/(1.0 - rating) to convert rating to
probability with which we should connect to that node when randomly
chosen
- it increases when we successfully establish a full outbound connection
to a node, and decreases when we fail to do that
- onion nodes have priority when using SOCKS
2017-07-05 09:17:01 +02:00
f5a143d0b8
Config validator
- config options can have validators
- limit maxoutboundconnections to max 8
2017-06-27 13:19:12 +02:00
20e01860cf
Network status peer list shouldn't be editable 2017-06-27 13:16:41 +02:00
26eb54a82e
Network status updates
- now lists each node with its info instead of a per-stream summary
2017-06-24 12:16:12 +02:00
bfbdd7e140
Chan address validator button feedback
- During validation, the button not only turns gray but also changes
label
2017-06-24 12:14:23 +02:00
2685fe29b1
Code quality improvements 2017-06-24 12:13:35 +02:00
7f06cb7c27
Inventory flush fix in GUI
- Fixes #1011
2017-06-10 10:10:59 +02:00
f366447e94
Fix identicon imports 2017-06-10 10:09:14 +02:00
e522f015a8
Network status updates
- only update processed numbers once every 2 seconds
- moved inventory lookups to the main inventory so now all
storage modules work with it
2017-05-31 10:15:47 +02:00
c85d52b8e8
Asyncore updates
- asyncore is now on by default
- inv announcements implemented
- bandwidth limit implemented / fixed
- stats on download / upload speed now work
- make prints into logger
- limit knownNodes to 20k as it was before
- green light fixed
- other minor fixes
2017-05-29 00:24:07 +02:00
9683c879bc
Asyncore update
- Network status UI works but current speed isn't implemented yet
- Track per connection and global transferred bytes
- Add locking to write queue so that other threads can put stuff
there
- send ping on timeout (instead of closing the connection)
- implement open port checker (untested, never triggered yet)
- error handling on IO
2017-05-25 14:59:18 +02:00
198470f734
Revert parser/renderer max message size
- it's now dealt with during decoding
2017-05-15 12:25:30 +02:00
9f4a1fa0a4
Config file defaults and address unification
- bmconfigpaser.py now allows to put default values for a specific
option in the file
- addresses as sections are now detected by "BM-" rather than
just ignoring bitmessagesettings. There can now be other sections
with a cleaner config file
2017-05-15 12:18:07 +02:00
660997f8e7
Quick hack for excessively long messages
- only process the first MB of a message for GUI purposes
(parsing/rendering)
2017-05-14 15:40:35 +02:00
e6f0b34f9b
Fixed some inconvenience on first run mainly in Ubuntu.
- immediately return from initCL() if numpy or pyopencl is unevailable
   (no ImportError because of resetPoW() call)
 - use glob to find C extension even if it named like
   `bitmsghash.x86_64-linux-gnu.so`

If user chooses to show the Settings dialog:

 - activate the "Network Settings" tab
 - remove option 'dontconnect' if settings have been saved
2017-04-05 14:25:02 +03:00
1af49a0165
Download tracking refactoring
- replace PendingDownload singleton dict with a Queue
- total memory and CPU requirements should be reduced
- get rid of somObjectsOfWhichThisRemoteNodeIsAlearedyAware. It has very
little practicle effect and only uses memory
2017-03-19 22:08:00 +01:00
ee7e630694
Show a dialog with QR-code for selected bm-address 2017-03-06 18:00:23 +02:00
9836206402
Missed translations: namecoin and welcom message 2017-03-05 23:07:18 +02:00
8d829b587e
Reset OpenCL when settings change
- previously, changing the OpenCL vendor (or turning it on/off) required
  a restart and this wasn't clear
2017-02-28 22:59:44 +01:00
171bc83ec0
HTML parser fix
- URLs followed with space were broken
2017-02-28 22:47:56 +01:00
eaafb9efa5
Listening port shouldn't be grey 2017-02-28 22:04:34 +01:00
741ac5ca05
UPnP recommendation notification fixes
- notify also if no connections and no change
2017-02-27 16:18:22 +01:00
ff786725ed
Typo
- UPnP / connectivity recommendation was active when on proxy rather
  than without
2017-02-27 16:12:19 +01:00
cd0972c0f3
Recommend enabling UPnP on network problems
- it looks like there aren't enough listening nodes
- if connection is dropped, notify non-proxy users about the UPnP option
2017-02-27 15:30:19 +01:00
cff1af1b4f
Subscription wrong tab
- when subscribing from addressbook, it switched to blacklist tab
  instead of subscriptions
2017-02-26 20:03:47 +01:00
d7076626c2
TTL label is in red and warning when too low
- TTL to chans shouldn't be too low so the UI gives a feedback
- warning when sending wouldn either require a lot of refactoring or
  wouldn't have good usability
2017-02-22 16:07:39 +01:00
e9899743ef
Typos, formatting, obsolete imports 2017-02-22 15:09:36 +01:00
af1bed9034
MessageView Unicode HTML fix
- the HTML on/off click label should be unicode rather than str
2017-02-22 12:30:14 +01:00
57a3c35299
Context menu on messages to deleted accounts
- messages from deleted chans still stay in global inbox
- this crated problems with account detection
- created NoAccount class for such accounts
2017-02-22 12:15:52 +01:00
6062277d60
Rename configparser.py to bmconfigparser.py
- it was causing problems with py2app because the source of python's own
  CongigParser is also configparser.py
2017-02-22 09:34:54 +01:00
266d8eba1f
SafeHTMLParser unicode / subprocess
- don't do subprocess in SafeHTMLParser, it doesn't work in frozen mode
  and an attempt to fix it would take too much refactoring and I'm not
  even sure it would work
- instead, make it handle broken unicode correctly
- I think the previous reports of freezes were caused by trying to
  interpret data as unicode, causing a crash
- it does about 1MB/s on my machine, so a timeout is not a big problem
2017-02-22 09:05:05 +01:00
Justin Ramos
fd95f8f519
allowing for max outbound connection configuration
Signed-off-by: Justin Ramos <justin.ramos@gmail.com>
2017-02-21 16:28:54 -06:00
46a2c361de
Building and msgpack fixes
- Makefile typo
- pyinstaller rewritten and fixed including and initialisation of
  messagetypes
- msgpack decoding new message display fix
2017-02-19 19:48:45 +01:00
f499a3b1d8
Typo 2017-02-14 13:57:20 +01:00
a4b1a781ce
Minor UI fixes
- "new" folder consistently appears in chans and "All accounts"
- "Sent" message list sorting fix
- When editing a label, keys.dat is saved and the lineEdit completer
  is updated
- addressbook is updated when adding/deleting a new chan
2017-02-14 01:35:32 +01:00
d8ae44f9ee
Obsolete imports, missing exception type 2017-02-09 21:04:07 +01:00
c778b81427
knownNodes refactoring and shutdown fixes
- saveKnownNodes replaced the repeated pickle.dump
- with knownNodesLock instead of acquire/release
- outgoingSynSender had an unnecessary loop during shutdown causing
  excessive CPU usage / GUI freezing
2017-02-09 11:53:33 +01:00
157881bc63
Cyclic import fix
- networkDefaultProofOfWorkNonceTrialsPerByte and
  networkDefaultPayloadLengthExtraBytes cyclic import fix
- PyBitmessage should launch now when there's no keys.dat
2017-02-08 20:37:42 +01:00
2cc4435cfc
Imports, typos, syntax errors
- remove obsolete imports
- add missing imports
- fix typos
- fix syntax errors
- thanks to landscape.io for report
2017-02-08 14:19:02 +01:00
59f3a2fbe7
Reduce cyclic dependencies
- rearranged code to reduce cyclic dependencies
- doCleanShutdown is separated in shutdown.py
- shared queues are separated in queues.py
- some default values were moved to defaults.py
- knownnodes partially moved to knownnodes.py
2017-02-08 13:41:56 +01:00
a381f75b4b
Git head information in version
- About dialog now shows the git head
- git head check has been improved to point to the head rather than the
  previous commit
2017-02-07 20:46:30 +01:00
6b65dfeeec
MarkAllUnread sqlite argument limit
- shouldn't crash anymore if there are too many messages to mark read
2017-02-07 16:38:02 +01:00
5ae1327edc
Download/upload shutdown fixes
- Missing renamed to PendingDownload
- PendingDownload now only retries 3 times rather than 6 to dowload an
  object
- Added PendingUpload, replacing invQueueSize
- PendingUpload has both the "len" method (number of objects not
  uploaded) as well as "progress" method, which is a float from 0
  (nothing done) to 1 (all uploaded) which considers not only objects
  but also how many nodes they are uploaded to
- PendingUpload tracks when the object is successfully uploaded to the
  remote node instead of just adding an arbitrary time after they have
  been send the corresponding "inv"
- Network status tab's "Objects to be synced" shows the sum of
  PendingUpload and PendingDownload sizes
2017-01-19 19:48:12 +01:00
9ed59dd825
Shutdown procedure cleanup 2017-01-16 23:38:18 +01:00
805f72e098
Make objects to be send stoppable if not empty 2017-01-15 22:21:19 +01:00
f079ff5b99
Refactor objects to be downloaded
- moved logic into a Missing singleton
- shouldn't try to download duplicates anymore, only requests a hash
  once every 5 minutes and not from the same host
- removed obsoleted variables
- the "Objects to be synced" in the Network tab should now be correct
- removed some checks which aren't necessary anymore in my opinion
- fix missing self in Throttle (thanks landscape.io)
2017-01-15 19:21:24 +01:00
8cb0953401
Moved writeKeysFile into configparser
- shared.writeKeysFile -> BMConfigParser().save
- makes it easier to get rid of circular imports
2017-01-15 10:50:02 +01:00
5ca8a52662
Typos, extra imports and similar
- pointed out by landscape.io
- also updated dev/ssltest.py to work the same way as the main program
2017-01-15 10:48:29 +01:00
689d697a40
Refactor bandwidth limit and speed calculator
- also fixes potential deadlocks
2017-01-14 23:21:00 +01:00
ad75552b5c
Move shutdown from shared.py to state.py 2017-01-14 23:20:15 +01:00
8d278182a7
Indentation 2017-01-13 15:53:47 +01:00
93bdc3c800
Remove extra print 2017-01-13 12:32:26 +01:00
d0b1cbfe1f
Add current git HEAD info to support request 2017-01-13 12:29:14 +01:00
5ae676f2ad
Minor support fix 2017-01-13 12:05:39 +01:00
6778d6046f
Add OpenSSL 1.1.0 compatibility
- thanks to Wolfgang Frisch <wfr@roembden.net>
2017-01-13 12:02:34 +01:00
ff8deebf60
Keep track of network protocol status 2017-01-12 19:18:56 +01:00
c738d93056
Assorted fixes
- landscape.io was complaining, this fixes most easily fixable errors
2017-01-11 18:13:00 +01:00
fa0a3135e7
Fixes pointed out by landscape.io
- missing/wrong/obsolete imports
- logger formatting
2017-01-11 17:26:25 +01:00
ac348e4e6b
Fixes and refactoring
- fixes errors introduced in the earlier refactoring
- more variables moved to state.py
- path finding functions moved to paths.py
- remembers IPv6 network unreachable (in the future can be used to skip
  IPv6 for a while)
2017-01-11 17:00:00 +01:00
8bcfe80ad0
Refactoring of config parser and shared.py
- got rid of shared config parser and made it into a singleton
- refactored safeConfigGetBoolean as a method of the config singleton
- refactored safeConfigGet as a method of the config singleton
- moved softwareVersion from shared.py into version.py
- moved some global variables from shared.py into state.py
- moved some protocol-specific functions from shared.py into protocol.py
2017-01-11 14:27:19 +01:00