str.join() only take exactly one argument, but xx given start from src. [python 2.7] #1288
Labels
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
No Milestone
No project
No Assignees
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Bitmessage/PyBitmessage-2024-12-03#1288
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
May we change the code
''.join(,,,)
to'{}{}{}'.format(,,,)
?The error
too many arguments given
raised insrc/bitmessagecli.py
, runing from python2.7.It's probably another untested change from @coffeedogs:
e0d31d7
kiksed (:Try this patch
That's lint, a little change appending:
Indeed, missing square brackets was not picked up by code review. As for tests, it remains a shame that we have no tests. I'm currently working on getting the QT app being driven by tests. I'll take a look at automating testing the CLI afterwards. @g1itch would you like me to submit a patch or are you already submitting the above diff?
I would really appreciate it, @g1itch, if you would stop blaming me for the decision to allocate my time towards code cleanup. I know exactly the problems that such an approach has, the types of bugs that arise, especially putting the new guy on it. However that risk was assessed and accepted by our respected team lead so please let's just deal with the consequences in a friendly manner. We should have the courage to change code. The v0.6 branch is not a release, it does not have to be perfect at all times.
I'm afraid errors like this are inevitable if we're cleaning up the code. It would require extraordinary amount of resources to avoid these kind of problems at this stage of the project, which I don't have. For the time being, I'm ok with minor breakages as long as they are reported and fixed quickly.
Please apply and submit it yourself. Maybe you'll find something more in bitmessagecli in process. The last comment is mysterious for me, @peter-tank what it means? Personally I don't care about bitmessagecli because I don't use it, don't understand, so cannot test locally if it works properly.
But maybe I will review PR's for such code which not concerns me, in order to spot such obvious mistakes.
Sorry for confused @coffeedogs
Every one like GUI, except me... It's sad.
I made more changes on
src/bitmessagecli.py
, can you help to review and pull it?These changes seems functionable, but for coder maybe it's too ugly.
As you can see but a new guy's trying.
Fw:
andRe:
, and multi-line mail allowed now.ackData
in this way).