Bitmessage/PyBitmessage-2024-12-03
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

to demo utf8, emoji logging without exception #1093

Closed
sigoa wants to merge 2 commits from patch-2 into master
pull from: patch-2
merge into: Bitmessage:master
Conversation 3 Commits 2 Files Changed 1 +18
sigoa commented 2018-01-22 13:30:14 +01:00 (Migrated from github.com)
Copy Link

to demo utf8, emoji logging without exception

as requested by Peter via BM recently

to demo utf8, emoji logging without exception as requested by Peter via BM recently
🎉 1
PeterSurda (Migrated from github.com) reviewed 2018-01-22 22:12:32 +01:00
src/bitmessagemain.py
PeterSurda (Migrated from github.com) commented 2018-01-22 22:12:32 +01:00

Please rename to something else than "emoji", e.g. something with utf8, unicode or encoding.

Please rename to something else than "emoji", e.g. something with utf8, unicode or encoding.
PeterSurda (Migrated from github.com) reviewed 2018-01-22 22:13:38 +01:00
src/bitmessagemain.py
PeterSurda (Migrated from github.com) commented 2018-01-22 22:13:38 +01:00

Please get rid of the logger.warning or replace it with something more neutral, like "logger encoding reset", and it should be .info or .debug, not .warning.

Please get rid of the logger.warning or replace it with something more neutral, like "logger encoding reset", and it should be .info or .debug, not .warning.
PeterSurda commented 2018-01-22 22:15:19 +01:00 (Migrated from github.com)
Copy Link

The commit is against the master branch, please rebase against v0.6, other than that it looks fine.

The commit is against the master branch, please rebase against v0.6, other than that it looks fine.
sigoa commented 2018-01-25 06:47:01 +01:00 (Migrated from github.com)
Copy Link

works nicely here. no other changes needed in logging functions calls. handy, huh?

works nicely here. no other changes needed in logging functions calls. handy, huh?
❤️ 1
PeterSurda commented 2018-01-25 08:10:12 +01:00 (Migrated from github.com)
Copy Link

I tested it and it works if your locale is utf-8. If it isn't and the error message has non-ascii characters, it still is broken. However I figured out how to fix both.

I tested it and it works if your locale is utf-8. If it isn't and the error message has non-ascii characters, it still is broken. However I figured out how to fix both.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.6.3
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-03#1093
No description provided.
Delete Branch "patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?