list index out of range traceback when no connects found or file corrupt. #1335
Labels
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
No Milestone
No project
No Assignees
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Bitmessage/PyBitmessage-2024-12-04#1335
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
random choice need a list to Generates a random sample from a list, but in connection pool it find self.stream empty and through list index out of range traceback:
Exception in thread Asyncore:
Traceback (most recent call last):
PyBitmessage/src/helper_random.py", line 65, in randomchoice
return random.choice(population) # nosec
File "/usr/lib/python2.7/random.py", line 275, in choice
return seq[int(self.random() * len(seq))] # raises IndexError if seq is empty
IndexError: list index out of range
2018-08-09 13:28:22,901 - WARNING - No notification.sound plugin found
Looks like when
knownnodes
is empty, an exception is thrown.I suspect that it caused by wrong import order in
bitmessagemain
. Can you please provide a steps to reproduce?yes.
this happens, when knownnodes.dat is empty or corrupted*,
but parsing dont raise an exception
to trigger createDefaultKnownNodes.
patch:
in knownnodes.py
after createDefaultKnownNodes()
insert:
*corrupted?
blame the file, or blame the parser?
see knownnodes.py
the if condition is never satisfied,
so old nodes are not added.
somehow, old pickle and new json format got mixed up.
in my pickle-coded knownnodes.dat
params is a dict, and looks like this
{'rating': 0, 'self': False, 'lastseen': 1538113792}
i suggest:
ps, have a look at El Paquete Semanal,
for 'more' decentral file sharing.
our main problem is,
we still depend on 'their' infrastructure.
see also Freifunk.
would love to see 'bridges' like XMPP transports.
kinda like a high-latency broadcast protocol.
hope to help ^^
ps2, still waiting for bm to connect ....
it did fall back to the nine hard-coded DEFAULT_NODES,
but none shows up in network status.
ping-ing the nodes does work.
@milahu Too many questions and unrelated stuff (:
Do you indeed update from BM < 6 so it has an old pickle knownnodes format? Could you please provide such file?
what a problem to import zero nodes from empty list? Yes default nodes should be added in this case. Though if the
knownnodes.dat
is really empty file it crashes withEOFError
No need to deduplicate dict because its keys are unique. What
old_stream
, did you implement streams?no .... i guess it was 0.6.3.2
in the logfile, i could not find the bm version.
in debug.py line 130 insert before 'if msg:'
my knownnodes.dat.bak has around 700kB with around 6k nodes.
sounds much to me ....
here is a sample file, with randomized ip addresses.
knownnodes.dat.bak.2.gz
created with
my_pickle.py.txt
but my last patch dont work.
all nodes seem duplicates.
that is, because pickle_deserialize_old_knownnodes
does overwrite knownNodes
knownnodes.py should look like this
why i still look for duplicates?
cos knownNodes has 2 keys, stream and node.
so one node can be in multiple streams.
old_stream and old_node are indices for the 'old' knownNodes,
where stream and node are indices for the 'new' new_knownNodes.
and ta-daa, its working : D
restored all 6k nodes + is connecting
im happy.
#1336 is an attempt to fix it but it's wrong. See my comments there. I haven't tried reproducing it myself, but what could happen is that all known nodes expire when your internet is down.
If the list is empty, it should re-bootsrap in my opinion.
Oh, you trying to use
knownnodes.dat
populated with random IPs. What you expect?I see no point to repopulate dict with its values. Because for the latest pickle format
pickle.load()
should be sufficient.no. if my
knownnodes.dat
has 6k nodes, but zero are loaded,there must be something wrong with the parser.
that was a sample file, to test parsing.
i have the original file here, did apply the patch above, and it works.
all nodes are loaded, bm connects, and stores nodes in new json format.
but i still have no idea, why it did store in pickle format.
i only let you know, how i did the ip randomization.
as i said, im happy. do what you want.
There are actually two problems. The first one is in parsing. The second one is that if knownnodes for whatever reason becomes empty, the Asyncore loop will start consuming a lot of CPU.
It was probably introduced in
342e2a2