Bitmessage/PyBitmessage-2024-12-04
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

[Security] Update to PyQt5 #897

New Issue
Open
opened 2016-09-04 14:29:00 +02:00 by ghost · 22 comments
ghost commented 2016-09-04 14:29:00 +02:00 (Migrated from github.com)
Copy Link

As you know Qt4 is no longer receiving security updates, you should switch to Qt5 and its python bindings.
The switch from pyqt4 to pyqt5 should be relatively easy according to pyqt documentation on this topic (for example here).

As you know Qt4 is no longer receiving security updates, you should switch to Qt5 and its python bindings. The switch from pyqt4 to pyqt5 should be relatively easy according to pyqt documentation on this topic (for example [here](http://pyqt.sourceforge.net/Docs/PyQt5/pyqt4_differences.html)).
👍 2
bmng-dev commented 2016-09-05 14:35:15 +02:00 (Migrated from github.com)
Copy Link

It is not so much PyQt but Qt itself that is the issue. Windows XP is still a supported platform for PyBitmessage. However Windows XP (and Vista) is missing from Qt5's Supported Platforms, although Qt for Windows - Specific Issues indicate it might be possible to build Qt5 for Windows XP. I understand @PeterSurda builds Qt4 as part of the release process so it is up to whether he can successfully build Qt5 and ensure everything still works on Windows XP before switching.

It is not so much PyQt but Qt itself that is the issue. Windows XP is still a supported platform for PyBitmessage. However Windows XP (and Vista) is missing from [Qt5's Supported Platforms](http://doc.qt.io/qt-5/supported-platforms.html), although [Qt for Windows - Specific Issues](http://doc.qt.io/qt-5/windows-issues.html) indicate it might be possible to build Qt5 for Windows XP. I understand @PeterSurda builds Qt4 as part of the release process so it is up to whether he can successfully build Qt5 and ensure everything still works on Windows XP before switching.
ghost commented 2016-09-05 22:15:07 +02:00 (Migrated from github.com)
Copy Link

Qt4 is not maintained by the Qt project, when bugs are discovered, users can and will be hacked through the old Qt. Additionally, Windows XP is no longer LTS of Windows.
This is illogical.

Qt4 is not maintained by the Qt project, when bugs are discovered, users can and will be hacked through the old Qt. Additionally, Windows XP is no longer LTS of Windows. This is illogical.
ghost commented 2016-09-05 22:23:00 +02:00 (Migrated from github.com)
Copy Link

Documentation / Upstream says it is possible to build Qt5 for XP.

Additional reading sources: https://doc.qt.io/qt-5/supported-platforms-and-configurations.html
"using Qt 5.6, XP will be supported until March 16, 2019"

Documentation / Upstream says it is possible to build Qt5 for XP. Additional reading sources: https://doc.qt.io/qt-5/supported-platforms-and-configurations.html "using Qt 5.6, XP will be supported until March 16, 2019"
ghost commented 2016-11-25 14:28:02 +01:00 (Migrated from github.com)
Copy Link

Ping on the ticket.

@PeterSurda @bmng-dev do you plan to fix this at all, and if you will fix it what's the targeted version for this?
I also advise you to drop the idea of supporting an outdated, no longer supported, Microsoft system.

Ping on the ticket. @PeterSurda @bmng-dev do you plan to fix this at all, and if you will fix it what's the targeted version for this? I also advise you to drop the idea of supporting an outdated, no longer supported, Microsoft system.
bmng-dev commented 2016-11-29 07:39:10 +01:00 (Migrated from github.com)
Copy Link

Sorry @Ghost, it's not up to me. I don't know why @PeterSurda hasn't responded.

Sorry @Ghost, it's not up to me. I don't know why @PeterSurda hasn't responded.
PeterSurda commented 2016-11-29 09:56:19 +01:00 (Migrated from github.com)
Copy Link

There are no specific plans, there are higher priority things. I'd prefer code that works both with Qt4 and Qt5 if possible, if someone submits a pull request I'll be happy to look at it.

There are no specific plans, there are higher priority things. I'd prefer code that works both with Qt4 and Qt5 if possible, if someone submits a pull request I'll be happy to look at it.
Lvl4Sword commented 2017-06-28 06:42:33 +02:00 (Migrated from github.com)
Copy Link

@bmng-dev I'm confused as to why XP/Vista would be supported at all, since those are EOL according to Microsoft ( and thus should be updated/replaced )
I stand by ghost's advice on not standing by these out-of-date systems

@bmng-dev I'm confused as to why XP/Vista would be supported at all, since those are EOL according to Microsoft ( and thus should be updated/replaced ) I stand by ghost's advice on not standing by these out-of-date systems
bmng-dev commented 2017-06-30 12:02:17 +02:00 (Migrated from github.com)
Copy Link

@Lvl4Sword you and me both. I'm just someone who is interested in Bitmessage like you. I am not, nor have I ever been, involved in the decision making process of this project. At the time I responded to @ghost I thought Windows XP was supported because of things I had read from @PeterSurda (other issues here on github, on the forums, reddit, or on the bitmessage chan I can't remember) and tried to be helpful with a timely response anticipating what some of @PeterSurda concerns might be about moving to Qt5. The jury is still out on whether I'm correct or not.

@Lvl4Sword you and me both. I'm just someone who is interested in Bitmessage like you. I am not, nor have I ever been, involved in the decision making process of this project. At the time I responded to @ghost I thought Windows XP was supported because of things I had read from @PeterSurda (other issues here on github, on the forums, reddit, or on the bitmessage chan I can't remember) and tried to be helpful with a timely response anticipating what some of @PeterSurda concerns might be about moving to Qt5. The jury is still out on whether I'm correct or not.
PeterSurda commented 2017-06-30 14:48:50 +02:00 (Migrated from github.com)
Copy Link

Just to clarify:

  • at the moment, the backwards compatibility with Windows doesn't appear to create extra effort. I build the 32bit binaries on Windows 7, and while I do have a test environment for XP, I don't recall having problems since switching the build environment to Windows 7. Today's devel snapshot also works on Windows XP, even though I haven't done any tests on XP since releasing 0.6.2. I haven't really tested most of the post-0.6.2 changes on anything else than linux for that matter. It's possible that at some stage the backwards compatibility will break, and I'll make a decision at that time.

  • the reason why I haven't switched to PyQt5 is that it's lower priority than other things. I don't know what the differences between Qt4 and Qt5 are and I'm not a UI specialist.

Just to clarify: - at the moment, the backwards compatibility with Windows doesn't appear to create extra effort. I build the 32bit binaries on Windows 7, and while I do have a test environment for XP, I don't recall having problems since switching the build environment to Windows 7. Today's devel snapshot also works on Windows XP, even though I haven't done any tests on XP since releasing 0.6.2. I haven't really tested most of the post-0.6.2 changes on anything else than linux for that matter. It's possible that at some stage the backwards compatibility will break, and I'll make a decision at that time. - the reason why I haven't switched to PyQt5 is that it's lower priority than other things. I don't know what the differences between Qt4 and Qt5 are and I'm not a UI specialist.
a17r commented 2018-02-15 16:38:47 +01:00 (Migrated from github.com)
Copy Link

Please note that Qt4 and PyQt4 support is being dropped in distributions everywhere at this point, since being unmaintained for years.

Please note that Qt4 and PyQt4 support is being dropped in distributions everywhere at this point, since being unmaintained for years.
PeterSurda commented 2018-02-15 18:13:37 +01:00 (Migrated from github.com)
Copy Link

Sadly, I'm busy with more urgent issues and I've never used PyQt5 before. Maybe someone else can do that. @g1itch any interest?

Sadly, I'm busy with more urgent issues and I've never used PyQt5 before. Maybe someone else can do that. @g1itch any interest?
g1itch commented 2018-02-15 18:16:07 +01:00 (Migrated from github.com)
Copy Link

Actually I started already. And have first preview.

Actually I started already. And have first preview.
👍 2
PeterSurda commented 2018-02-15 18:19:22 +01:00 (Migrated from github.com)
Copy Link

Excellent, thank you very much!

Excellent, thank you very much!
👍 1
g1itch commented 2018-02-15 18:35:52 +01:00 (Migrated from github.com)
Copy Link

The branch

[The branch](../../../g1itch/PyBitmessage/tree/qt5)
PeterSurda commented 2018-02-19 23:53:33 +01:00 (Migrated from github.com)
Copy Link

@g1itch I sent you an email, did you get it?

@g1itch I sent you an email, did you get it?
g1itch commented 2018-02-20 07:45:58 +01:00 (Migrated from github.com)
Copy Link

Yes, I'll try to grab some words and give a proper answer.

Yes, I'll try to grab some words and give a proper answer.
g1itch commented 2018-02-22 16:47:36 +01:00 (Migrated from github.com)
Copy Link

Huh, it's almost done. I guess it will require a massive beta-test (or alpha?). I've used QtPy, so it will be compatible with PyQt4 and pyside.

Huh, it's almost done. I guess it will require a massive beta-test (or alpha?). I've used [QtPy](https://pypi.python.org/pypi/QtPy), so it will be compatible with PyQt4 and pyside.
NourEddineX commented 2018-11-23 05:44:56 +01:00 (Migrated from github.com)
Copy Link

Hello , please note that PyQt4 has been dropped from Manjaro, one of major desktop linux distros

Hello , please note that PyQt4 has been dropped from Manjaro, one of major desktop linux distros
Jacalz commented 2019-01-10 13:02:54 +01:00 (Migrated from github.com)
Copy Link

Solus are planning to deprecate Qt4, getting it ported to Qt5 would make it possible to still be included in the repo...

Solus are planning to deprecate Qt4, getting it ported to Qt5 would make it possible to still be included in the repo...
👍 1
g1itch commented 2019-01-10 13:05:50 +01:00 (Migrated from github.com)
Copy Link

Solus are planning to deprecate Qt4, getting it ported to Qt5 would make it possible to still be included in the repo...

It's already ported, just still is not included into v0.6. You can take my qt5-wip branch for you repo.

> Solus are planning to deprecate Qt4, getting it ported to Qt5 would make it possible to still be included in the repo... It's already ported, just still is not included into `v0.6`. You can take my `qt5-wip` branch for you repo.
👍 1 🎉 1
Jacalz commented 2019-01-10 13:07:16 +01:00 (Migrated from github.com)
Copy Link

Wonderful, that is great news 👍

Wonderful, that is great news :+1:
baerbock commented 2019-05-04 17:10:50 +02:00 (Migrated from github.com)
Copy Link

Hello , please note that PyQt4 has been dropped from Manjaro, one of major desktop linux distros

LOL. Manjaro is ArchLinux with parental advisory!

> Hello , please note that PyQt4 has been dropped from Manjaro, one of major desktop linux distros LOL. Manjaro is ArchLinux with parental advisory!
😆 1
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.7.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-04#897
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?