fixed CQ for bitmessageqt.retranslateui module #1650

Open
coolguy-cell wants to merge 1 commits from coolguy-cell/CQfixes11 into v0.6

View File

@ -1,9 +1,12 @@
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
from os import path """RetranslateMixin module.
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
"""
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
# pylint: disable=too-few-public-methods
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
from PyQt4 import QtGui from PyQt4 import QtGui
from debug import logger
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
import widgets import widgets
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
class RetranslateMixin(object): class RetranslateMixin(object):
"""RetranslateMixin class for dynamically change language during runtime."""
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
def retranslateUi(self): def retranslateUi(self):
defaults = QtGui.QWidget() defaults = QtGui.QWidget()
widgets.load(self.__class__.__name__.lower() + '.ui', defaults) widgets.load(self.__class__.__name__.lower() + '.ui', defaults)
@ -13,6 +16,8 @@ class RetranslateMixin(object):
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
getattr(self, attr).setText(getattr(defaults, attr).text()) getattr(self, attr).setText(getattr(defaults, attr).text())
elif isinstance(value, QtGui.QTableWidget): elif isinstance(value, QtGui.QTableWidget):
for i in range(value.columnCount()): for i in range(value.columnCount()):
getattr(self, attr).horizontalHeaderItem(i).setText(getattr(defaults, attr).horizontalHeaderItem(i).text()) getattr(self, attr).horizontalHeaderItem(i).setText(
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
getattr(defaults, attr).horizontalHeaderItem(i).text())
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
for i in range(value.rowCount()): for i in range(value.rowCount()):
getattr(self, attr).verticalHeaderItem(i).setText(getattr(defaults, attr).verticalHeaderItem(i).text()) getattr(self, attr).verticalHeaderItem(i).setText(
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
getattr(defaults, attr).verticalHeaderItem(i).text())
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording

PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:27:25 +02:00 (Migrated from github.com)
Review

Can you come up with a better docstring?

Can you come up with a better docstring?
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-06-17 08:28:44 +02:00 (Migrated from github.com)
Review

Like something about being able to dynamically change language during runtime.

Like something about being able to dynamically change language during runtime.
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:23 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording
PeterSurda commented 2020-07-07 10:53:54 +02:00 (Migrated from github.com)
Review

better wording

better wording