Strange log messages started to appear with recent code changes #1834
Labels
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
No Milestone
No project
No Assignees
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Bitmessage/PyBitmessage-2024-12-06#1834
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hello!
With recent code I see this log message when opening any 'inbox' folder in the
bitmessageqt
appUPD: it appears without any action, probably related to sending a pubkey
Introduced in
6dffb1e
or earlier, I'm checking it with the appimage: https://github.com/g1itch/PyBitmessage/actions/runs/1174396926Check your "Sent" folder, you may have a broadcast queued for an address that is now deleted. It's only improved logging that changed, before it would also try to send a broadcast but just silently fail.
Maybe check with sqlite command line tool even, I'm not sure it would show up in "Sent" if the address has been deleted in the meantime.
Good night! Found it:
The error messages now also have improved accuracy, if it says
sendBroadcast didn't work
, it really meanssendBroadcast
didn't work, rather than a pubkey or some other object. Step by step things are getting better.Shouldn't it also report an error for these 10 broadcasts?
Now I see many warnings about "Proof of Work exception" which are wrong, please see my comments on
fc19c54
I always suggest writing tests to avoid exactly such cases. Before editing the code you need to understand and document what it does, I think.
You can also see it in the recent buildbot runs, e.g. https://buildbot.bitmessage.org/#/builders/25/builds/2180/steps/8/logs/stdio, line 852.
This is the effect of missing return: https://buildbot.bitmessage.org/#/builders/25/builds/2220/steps/8/logs/stdio, line 846
This one is also started to appear lately:
And the "Proof of Work exception" right after it.