Commit Graph

2623 Commits

Author SHA1 Message Date
lakshyacis
81872c7f2f
network code quality fixes 2020-01-08 12:53:04 +05:30
lakshyacis
a31d6c8422
sound_playfile quality fixes 2020-01-07 15:27:17 +05:30
lakshyacis
8338a9ee74
sound_gstreamer docstring fixes 2020-01-07 15:27:16 +05:30
lakshyacis
208090ce5d
sound_canberra docstring and formatting 2020-01-07 15:27:16 +05:30
lakshyacis
e24f4de40e
proxyconfig_stem quality fixes 2020-01-07 15:27:16 +05:30
lakshyacis
ea50485de2
notification_notify2 pylint fixes 2020-01-07 15:27:15 +05:30
lakshyacis
7b0bf84585
menu_qrcode docstring and formatting 2020-01-07 15:27:15 +05:30
lakshyacis
624d96fbb9
indicator_libmessaging docstring and formatting 2020-01-07 15:27:14 +05:30
lakshyacis
8659c5313d
openssl pylint issue fixes 2020-01-07 13:20:31 +05:30
lakshyacis
814aae5166
eccblind quality fixes 2020-01-07 13:20:31 +05:30
lakshyacis
36c24cc09a
cipher quality fixes 2020-01-07 13:20:30 +05:30
lakshyacis
b16515dc09
arithmetic docstring and formatting 2020-01-07 13:20:30 +05:30
lakshyacis
4a369f70c1
formatting and docstring 2020-01-07 12:13:51 +05:30
lakshyacis
21ae6cb9b0
curses fixes 2020-01-06 19:18:05 +05:30
61f64f72c3
Fixing port for hidden service 2020-01-04 14:28:45 +02:00
1c4d7655c3
Fix socksproxytype in the support message,
made that a separate function getSOCKSProxyType(config) in the settings.
2020-01-04 14:28:45 +02:00
52d5c1ff03
Document proxyconfig_stem 2020-01-04 14:28:45 +02:00
2bddae511a
Fixed some mistakes in tor dependent tests and marked them
for skipping until the finish of debug.
2020-01-04 14:28:45 +02:00
e3ccc3c7c8
Support for socksproxytype plugins in Settings dialog 2020-01-04 14:28:45 +02:00
5160a68c28
Moved start_proxyconfig to helper_startup;
no more prints in helper_startup
2020-01-04 14:28:45 +02:00
44cb975a61
Fixed bug in plugin.get_plugins(), edited docstrings 2020-01-04 14:28:44 +02:00
c35f48bd0b
Fix setting socksproxytype and return in proxyconfig_stem:
socksproxytype is set to SOCKS5 temporary if proxyconfig succeeds.
2020-01-04 14:28:44 +02:00
sandakersmann
9119507b03
Changed copyright year to 2020 2019-12-27 18:23:02 +01:00
03316496b7
Stop UDPSocket on socket.error 101 (Network is unreachable) 2019-12-24 12:41:01 +02:00
5a35de6bca
Fix sendOnionPeerObj() broken in 9923e97 2019-12-21 13:14:28 +02:00
c79636863d
If tray is not available, disable settings group "Tray"
and related checkboxes; set checkBoxMinimizeToTray to false by default
2019-12-20 11:25:15 +02:00
a69732f060
Addrthread finish
- addrthread is supposed to spread addresses as they appear. This was never
  finished during migration to asyncore
- conservative to prevent flood and loops
- randomises order
- move protocol constants into a separate file
- move addr packet creation into a separate file
- see #1575
2019-11-30 13:47:24 +01:00
lakshyacis
e47b573b3e
helper_sql pylint fixes 2019-11-25 15:17:40 +05:30
lakshyacis
ece3005f42
helper_sent pylint fixes 2019-11-25 15:17:40 +05:30
lakshyacis
d271996ac1
helper_sent flake8 fixes 2019-11-25 15:17:40 +05:30
lakshyacis
d5f541a2ab
helper_search pylint fixes 2019-11-25 15:17:40 +05:30
lakshyacis
9041b8f644
helper_search flake8 fixes 2019-11-25 15:17:40 +05:30
lakshyacis
28cfe78e67
helper_random pylint fixes 2019-11-25 15:17:40 +05:30
lakshyacis
05cda087d6
helper_msgcoding pylint fixes 2019-11-25 15:17:40 +05:30
lakshyacis
f4c7ac5604
helper_inbox pylint fixes 2019-11-25 15:17:40 +05:30
lakshyacis
27c58b05f3
helper_bitcoin pylint fixes 2019-11-25 15:17:32 +05:30
lakshyacis
31e3d60fb0
helper_ackPayload pylint fixes 2019-11-25 15:13:53 +05:30
lakshyacis
e97d02ed78
depends pylint fixes 2019-11-25 15:13:53 +05:30
lakshyacis
21faf52f2f
debug pylint fixes 2019-11-25 15:13:53 +05:30
lakshyacis
a9991a7a5a
class_sqlThread pylint fixes 2019-11-25 15:13:52 +05:30
lakshyacis
dbbf454c15
class_sqlThread flake8 fixes 2019-11-25 15:13:52 +05:30
lakshyacis
4a54c200d4
class_smtpServer quality fixes 2019-11-25 10:48:35 +05:30
lakshyacis
9923e97279
class_singleWorker quality fixes 2019-11-25 10:48:35 +05:30
lakshyacis
80b2bc1c9a
class_singleCleaner.py quality fixes 2019-11-25 10:48:29 +05:30
lakshyacis
059e82e2a2
class_objectProcessor quality fixes 2019-11-25 10:41:57 +05:30
lakshyacis
e534994ee3
class_addressGenerator quality fixes 2019-11-25 10:41:56 +05:30
lakshyacis
77b8b5aa42
bmconfigparser quality fixes 2019-11-25 10:41:56 +05:30
lakshyacis
af52d95503
bitmessagemain quality fixes 2019-11-25 10:41:55 +05:30
d9fa6a94f4
More docstrings and formatting fixes in highlevelcrypto and shutdown 2019-11-18 13:34:01 +02:00
a7da0c0eff
Fixed google style docstrings in addresses 2019-11-18 13:34:00 +02:00
aa7e7dd658
Fixed some docstrings in shared and state 2019-11-18 13:34:00 +02:00
f18f534c48
Formatted protocol and its docstrings 2019-11-18 13:34:00 +02:00
2a165380bb
Restrict outbound connections on network groups
Logic borrowed from bitcoin, see CNetAddr::GetGroup() in src/netaddress.cpp
Simplified, so may not work fully identically but for our purposes it's good
enough. Won't connect to more than one host from a /16 subnet on IPv4 and a /32
subnet on IPv6.
2019-11-18 12:20:29 +01:00
bug Lady
7e1f1d2604
fix 'true' not True
else error
2019-11-14 13:32:15 +01:00
35a2962552
Fixed misleading comment about receiveDataThreads in queues 2019-11-11 17:13:20 +02:00
c40c70f807
Marked variables comments in defaults for use in doc.
Allowed autodoc in bitmessagemain, class_objectProcessor, defaults:
seems safe now.

Changed docs conf: don't sort module members, treat any string
inside backticks as :obj:.
2019-11-11 17:13:20 +02:00
d6c1845b71
Moved Peer from state to network.node
and trustedPeer to network.connectionpool.BMConnectionPool attribute
2019-11-11 17:13:12 +02:00
388de96495
Alphabetical internal import order in bitmessagemain 2019-11-11 12:03:04 +02:00
0967f03b40
addresses: raise varintEncodeError in encodeVarint()
instead of SystemExit (looks like a bug)
2019-11-11 12:03:04 +02:00
7a1f803c92
network.BMConnectionPool: added shortcuts connections()
and establishedConnections(), some formatting fixes
2019-11-11 12:03:04 +02:00
4d8d9b169f
Moved ObjectProcessorQueue to queues, added some doc 2019-11-11 12:03:04 +02:00
341651973a
Reduced imports:
- exported from network package all objects used outside;
  - made all threads available in threads module.

Wrote some module docstrings.
2019-11-11 12:03:03 +02:00
lakshyacis
58e5fac6d7
tr quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
fda5d23c2d
state quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
b9ad6a3bac
singleinstance quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
503d0b33d0
shutdown quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
6f91ba1b33
shared quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
27be035e51
paths quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
cacac00e21
openclpow quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
1181db66e0
l10n quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
afce500085
knownnodes quality fixes 2019-10-31 14:52:43 +05:30
lakshyacis
ee5be28179
helper_threading quality fixes 2019-10-29 11:45:51 +05:30
1a7ef791e5
message_data_reader is obsolete 2019-10-28 09:14:48 +02:00
George McCandless
f871cd450c
Add test for 'onionservicesonly' mode.
Credit to Dmitri Bogomolov in commit 557a8cc6d2bec881b8a3c531d3f725460ed515f5.
2019-10-24 19:35:32 +00:00
George McCandless
b42f536d23
Add a checkbox to the network settings tab that allows restricting outbound connections to onion services (i.e., hosts that end with '.onion'). 2019-10-21 00:03:41 +00:00
f0b4e4ded4
Replaced logging.getLogger() in other possible places 2019-10-18 09:35:31 +03:00
a48b51721d
Test new logging approach, both debug.logger and resetLogging 2019-10-18 09:35:31 +03:00
bbdbca253b
Added warnings about changing port settings in api and network.tcp 2019-10-18 09:35:31 +03:00
d2a896697d
Used logger.isEnabledFor() to prevent unneeded calculations 2019-10-18 09:35:31 +03:00
7a89109fc9
New logging approach in order to reduce imports from submodules
and use logging without risk of circular import. Only subpackage
that imports from debug is bitmessageqt - because it also uses
debug.resetLogging().
Instead of from debug import logger is now recommended to use:

import logging

logger = logging.getLogger('default')

All subclasses of StoppableThread now have a logger attribute.
All threading related stuff except for set_thread_name()
was moved from helper_threading to network.threads.

Fixed two my mistakes from previous edit of debug in a1a8d3a:

 - logger.handlers is not dict but iterable
 - sys.excepthook should be set unconditionally
2019-10-18 09:35:24 +03:00
c63ed02153
Minimal changes to document Singleton and class definitions it wraps 2019-10-18 01:06:03 +03:00
86f0860cb2
Slightly rewritten docstrings in singleinstance 2019-10-18 01:06:03 +03:00
9e72e3b2af
Rewritten epytext strings in qidenticon and removed __all__ 2019-10-18 01:06:02 +03:00
53cc08edec
Renamed invalid python module http-old 2019-10-18 01:06:02 +03:00
4d15c8e590
Fix fallback package docstring 2019-10-18 01:06:02 +03:00
b5df242141
Fixed badly formatted docstrings and some wrong text 2019-10-18 01:06:02 +03:00
c99997dbb9
Fix mistakes in Exception() instantiation 2019-10-17 23:46:41 +03:00
9a438c1a1a
flake8: paths 2019-10-01 12:42:03 +03:00
lakshyacis
e5b92e29a2
vote pylint fixes 2019-09-30 18:42:50 +05:30
lakshyacis
9aa7dd9d78
message pylint fixes 2019-09-30 18:42:36 +05:30
lakshyacis
40e15579fd
messagetypes init flake and pylint fixes 2019-09-27 19:55:06 +05:30
lakshyacis
fba2d6d837
storage pylint fixes 2019-09-27 17:01:08 +05:30
lakshyacis
e924e9208f
storage flake8 fixes 2019-09-27 17:01:07 +05:30
lakshyacis
da5d085a39
sqlite pylint fixes 2019-09-27 17:01:07 +05:30
lakshyacis
54ebbcb7db
sqlite flake8 fixes 2019-09-27 17:01:07 +05:30
lakshyacis
ac341482d4
filesystem pylint fixes 2019-09-27 17:01:06 +05:30
lakshyacis
6f910f67c0
filesystem flake8 fixes 2019-09-27 17:01:06 +05:30
lakshyacis
433cb9818b
sound_playfile pylint fixes 2019-09-27 16:12:35 +05:30
lakshyacis
a86e43c108
sound_gstreamer pylint fixes 2019-09-27 16:12:35 +05:30
lakshyacis
a86c5188c4
sound_canberra pylint fixes 2019-09-27 16:12:35 +05:30
lakshyacis
df1994d6f3
proxyconfig_stem pylint fixes 2019-09-27 16:12:25 +05:30
lakshyacis
e50f99419f
plugin pylint fixes 2019-09-27 16:04:29 +05:30
lakshyacis
7aa9b94c11
notification_notify2 pylint fixes 2019-09-27 16:04:29 +05:30
lakshyacis
4c1568a3eb
menu_qrcode pylint fixes 2019-09-27 16:04:29 +05:30
lakshyacis
36775ae88b
indicator_libmessaging pylint fixes 2019-09-27 16:04:28 +05:30
lakshyacis
a6f951d37f
openssl pylint fixes 2019-09-27 13:11:58 +05:30
lakshyacis
4448e6ee7b
hash pylint fixes 2019-09-27 13:11:58 +05:30
lakshyacis
e0d81bb7e8
cipher pylint fixes 2019-09-27 13:11:40 +05:30
lakshyacis
fa65b17fc9
__init__ pylint fixes 2019-09-27 13:10:24 +05:30
lakshyacis
944c30f9b4
test_config pylint fixes 2019-09-26 19:51:02 +05:30
lakshyacis
7839f83f20
test_api pylint fixes 2019-09-26 19:50:53 +05:30
lakshyacis
8ed1d48799
core pylint fixes 2019-09-26 19:50:45 +05:30
88f2c51595
quzwelsuziwqgpt2.onion:8444 is also a bootstrap server 2019-09-25 18:55:02 +03:00
a7cfe5ba32
Try to test with tor 2019-09-25 18:55:01 +03:00
6a0c3ae075
Remove obsolete helper_bootstrap and bundled SocksiPy 2019-09-25 18:55:01 +03:00
bcb29facaa
A test for bootstrapping, have problem with test_tcpconnection ): 2019-09-25 18:55:01 +03:00
bdb09c2d00
Ignore self node in connectionchooser.chooseConnection() 2019-09-25 18:55:01 +03:00
7215003c6f
No DNS resolving in knownnodes 2019-09-25 18:55:01 +03:00
4825c5a136
Universal bootstrap procedure for any connection type 2019-09-25 18:55:01 +03:00
0a06567071
Connect to bootstrap nodes by name 2019-09-25 18:55:01 +03:00
42a89ad367
Delete from addressbook by pressing DEL 2019-09-24 14:59:12 +03:00
7d0e23e31a
Delete from addressbook only by address (Fixes: #1484) 2019-09-24 14:59:12 +03:00
lakshyacis
4c7f9487e2
init file fixes for pylint 2019-09-23 15:12:40 +05:30
24ae91ad0a
Set dontconnect temporary, completely avoiding saving 2019-09-20 14:31:52 +03:00
df66277e2d
state.resetNetworkProtocolAvailability() is obsolete 2019-09-20 14:31:51 +03:00
18392017c6
Do not propose user to restart Bitmessage
if network settings have changed, drop network connections instead
2019-09-20 14:31:51 +03:00
8a3074f3ff
ui-file based Settings dialog 2019-09-20 14:31:45 +03:00
lakshyacis
a961a4a2fb
proxy pylint fixes 2019-09-16 19:13:56 +05:30
lakshyacis
1e446b768c
node pylint fixes 2019-09-16 19:13:56 +05:30
lakshyacis
915bfb757d
networkthread pylint fixes 2019-09-16 19:13:55 +05:30
lakshyacis
e74affe636
udp pylint fixes 2019-09-16 19:13:55 +05:30
lakshyacis
498232dbea
tls pylint fixes 2019-09-16 19:13:54 +05:30
lakshyacis
dccb1dbb3c
tls flake8 fixes 2019-09-16 19:13:54 +05:30
lakshyacis
fcffb42629
stats pylint fixes 2019-09-16 19:13:54 +05:30
lakshyacis
7d0bd1cf7a
stats flake8 fixes 2019-09-16 19:13:53 +05:30
lakshyacis
8182e159df
socks5 flake8 fixes 2019-09-16 19:13:53 +05:30
lakshyacis
79d1b1b9e2
socks4a pylint fixes 2019-09-16 19:13:53 +05:30
lakshyacis
253cec15c4
proxy flake8 fixes 2019-09-10 16:08:18 +05:30
lakshyacis
fa6ef4f933
objectracker pylint fixes 2019-09-10 16:07:02 +05:30
lakshyacis
db1593f428
https flake8 fixes 2019-09-10 15:34:20 +05:30
lakshyacis
77651eebe3
objecttracker flake8 fixes 2019-09-10 15:34:20 +05:30
lakshyacis
ef77a9816e
invthread pylint fixes 2019-09-10 15:34:20 +05:30
lakshyacis
97cbe43294
invthread flake8 fixes 2019-09-10 15:34:20 +05:30
lakshyacis
28e954902d
httpd flake8 fixes 2019-09-10 15:34:20 +05:30
lakshyacis
2c71612a4b
http pylint fixes 2019-09-10 15:34:19 +05:30
lakshyacis
7eced454d1
http flake8 fixes 2019-09-03 19:56:59 +05:30
lakshyacis
68e09a5e30
http-old pylint fixes 2019-09-03 18:41:24 +05:30
lakshyacis
5fcb7fc05e
http-old flake8 fixes 2019-09-03 14:34:17 +05:30
lakshyacis
d8ea0afe40
downloadthread.py Pylint fixes 2019-09-02 19:15:15 +05:30
lakshyacis
8589f01d3d
downloadthread.py flake8 fixes 2019-09-02 19:02:50 +05:30
lakshyacis
b927d51eb3
dandelion.py pylint fixes 2019-09-02 13:53:06 +05:30
lakshyacis
f1b6b16940
connectionpool.py pylint fixes 2019-09-02 13:52:56 +05:30
lakshyacis
5521c16478
bmproto pylint fixes 2019-08-30 16:12:39 +05:30
lakshyacis
469d289a97
Announcethread Pylint Fixes 2019-08-30 15:23:20 +05:30
lakshyacis
548fcf0d0a
announcethread Flake8 Fixes 2019-08-29 19:24:13 +05:30
lakshyacis
b48197ff0d
build_osx file flake8 Fixes 2019-08-29 16:32:14 +05:30
lakshyacis
cc869d0426
bitmessagemain flake8 Fixes 2019-08-29 16:13:27 +05:30
395fbcd0f0
Add intermediary tests
- primitive serialisation (BN_bn2bin and ctypes) used in intermediary tests
2019-08-28 13:21:44 +02:00
b934c4e01e
Minor refactoring to separate objects 2019-08-27 23:13:58 +02:00
076aeaa19f
Import path changes as requested 2019-08-27 23:13:55 +02:00
2e0f7755c6
Blind signature support in pyelliptic
- add blind signature functionality to pyelliptic as described in #1409
- add tests for blind signatures
- PEP8 fixes for pyelliptic
- some minor refactoring is necessary for further integration, this is just a
  minimal implementation to pass a test
2019-08-27 23:13:45 +02:00
f180b1a5b0
Moved randomtrackingdict to network, it's used only there 2019-08-18 17:34:58 +03:00
709e194347
Fix #1504 (regression introduced in 0c1e516) 2019-08-16 12:32:16 +03:00
e8bd427b9f
flake8 for bitmessageqt.safehtmlparser (with docstrings from #1368) 2019-08-13 10:57:52 +03:00
97366ede73
Do not save hidden service parameters if onionhostname is set 2019-08-08 11:46:57 +03:00
53d77ce911
Dumb tor configurator using stem 2019-08-08 11:46:57 +03:00
ec11632297
Introduce pluggable proxy configurators 2019-08-08 11:46:50 +03:00
2bd75b87bd
Use config = BMConfigParser() in bitmessagemain.Main 2019-08-06 18:59:13 +03:00
d8d76ed42d
No random.seed() in protocol.assembleVersionMessage() 2019-08-06 18:11:38 +03:00
ad2a2b3fb4
Inherit helper_threading.StoppableThread from threading.Thread
and do random.seed() in its __init__
2019-08-06 18:07:19 +03:00
a7a634be1b
Add self peers with rating 1 2019-08-02 17:56:40 +03:00
92c0196887
Add self peer into knownnodes if detected external IP with UPnP 2019-08-01 13:21:05 +03:00
668a73abf6
Fixed my mistake in knownnodes, in ef54bca 2019-08-01 12:58:43 +03:00
ea5c447ea4
protocol: replace missing state.extPort by 'extport' setting
Fixes #1497
2019-08-01 12:40:50 +03:00
c5ce2e36d5
shared.extPort is obsolete 2019-08-01 12:40:50 +03:00
9992626438
Fix API command 'shutdown' 2019-08-01 12:04:13 +03:00
ae76d369f2
A test for API command 'shutdown' 2019-08-01 12:04:12 +03:00
27e74a15d7
flake8: network.connectionchooser 2019-07-29 15:54:19 +03:00
67d14f9e73
Docstrings in network.bmproto from #1362 2019-07-26 12:08:56 +03:00
bbab0010e6
Moved a test script from network.tcp to tests.core 2019-07-26 12:08:42 +03:00
391b5ded87
Docstrings in network from #1368 2019-07-26 12:08:32 +03:00
2998599442
Docstrings in network from #1401 2019-07-26 12:08:18 +03:00
19ab56a979
network.connectionpool: get any setting with .safeGet.. 2019-07-26 12:08:18 +03:00
996e71ae6f
flake8 in network package 2019-07-26 12:07:57 +03:00
0eb4f46923
Formatting based on review 2019-07-11 15:32:00 +02:00
465a276c02
Dandelion fixes
- expiration wasn't handled correctly
- objects with no child stems never expired. While this is better for
  anonymity, it can cause objects getting stuck
- upon expiration the nodes weren't marked as not having the object, causing it
  to not be advertised
- I haven't tested it but at least I don't think can make things worse
2019-07-11 11:03:48 +02:00
e07cd1462e
Added address menu plugins to each popup menu except for Blacklist,
closes #819
2019-07-08 16:56:41 +03:00
e6f3e52014
qrcode plugin: added address label and adjusted formatting 2019-07-05 12:36:03 +03:00
8b065d2e57
Fix unwanted AttributeError in messagetypes 2019-07-05 12:13:55 +03:00
c9bc97f4b2
Set status icon color to yellow if last inbound connection is lost 2019-06-29 22:37:35 +03:00
ff020c5192
fix windows header files api issue 2019-06-28 20:35:40 +05:30
f7e1601185
flake8 imports in blacklist 2019-06-21 16:47:47 +03:00
fbf5bcc74c
Blacklist object has no .statusBar() method - use UISignalQueue.put() 2019-06-21 16:47:42 +03:00
38e5d93272
Resend onionpeer object if it expired while the node ran 2019-06-14 12:38:48 +03:00
a5300e8584
Took into account pylint undefined-loop-variable warnings 2019-06-08 11:22:03 +03:00
0c1e516921
Implemented folder and widget args in propagateUnreadCount(), removed the rest 2019-06-08 11:22:03 +03:00
ffdd91b021
Fixed propagateUnreadCount() result when having unread messages in trash 2019-06-08 11:22:02 +03:00
29f9cd9545
Handle bad trustedpeer setting 2019-06-07 13:54:47 +03:00
f868c1ad11
Fixing my bug in 453e045 2019-06-06 09:21:59 +03:00
d0d0b2ec84
Insert exactly 16 bytes of encoded remote host name into version message 2019-05-24 11:21:23 +03:00