Blind signature support in pyelliptic #1509

Merged
PeterSurda merged 4 commits from blindsig1 into v0.6 2019-08-28 13:43:29 +02:00
Showing only changes of commit 076aeaa19f - Show all commits

View File

@ -4,7 +4,7 @@ Test for ECC blind signatures
g1itch commented 2019-08-27 11:09:52 +02:00 (Migrated from github.com)
Review

Shebang is not needed here.

Shebang is not needed here.
g1itch commented 2019-08-27 11:09:52 +02:00 (Migrated from github.com)
Review

Shebang is not needed here.

Shebang is not needed here.
g1itch commented 2019-08-27 11:15:09 +02:00 (Migrated from github.com)
Review

from pybitmessage.pyelliptic.eccblind import ECCBlind

`from pybitmessage.pyelliptic.eccblind import ECCBlind`
g1itch commented 2019-08-27 11:15:09 +02:00 (Migrated from github.com)
Review

from pybitmessage.pyelliptic.eccblind import ECCBlind

`from pybitmessage.pyelliptic.eccblind import ECCBlind`
g1itch commented 2019-08-27 11:16:07 +02:00 (Migrated from github.com)
Review

self.assertTrue(blind_sig.verify())

`self.assertTrue(blind_sig.verify())`
g1itch commented 2019-08-27 11:16:07 +02:00 (Migrated from github.com)
Review

self.assertTrue(blind_sig.verify())

`self.assertTrue(blind_sig.verify())`
g1itch commented 2019-08-27 11:19:42 +02:00 (Migrated from github.com)
Review

If you write docstring in one line it will be shown in the test results. e.g.

    def test_blind_sig(self):
        """Test full sequence using a random certifier key and a random msg"""
If you write docstring in one line it will be shown in the test results. e.g. ```python def test_blind_sig(self): """Test full sequence using a random certifier key and a random msg""" ```
g1itch commented 2019-08-27 11:19:42 +02:00 (Migrated from github.com)
Review

If you write docstring in one line it will be shown in the test results. e.g.

    def test_blind_sig(self):
        """Test full sequence using a random certifier key and a random msg"""
If you write docstring in one line it will be shown in the test results. e.g. ```python def test_blind_sig(self): """Test full sequence using a random certifier key and a random msg""" ```
PeterSurda commented 2019-08-27 12:25:00 +02:00 (Migrated from github.com)
Review

This breaks the test.

This breaks the test.
PeterSurda commented 2019-08-27 12:25:00 +02:00 (Migrated from github.com)
Review

This breaks the test.

This breaks the test.
g1itch commented 2019-08-27 12:27:08 +02:00 (Migrated from github.com)
Review

It depends on how you run it.

It depends on how you run it.
g1itch commented 2019-08-27 12:27:08 +02:00 (Migrated from github.com)
Review

It depends on how you run it.

It depends on how you run it.
g1itch commented 2019-08-27 12:28:27 +02:00 (Migrated from github.com)
Review

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8
g1itch commented 2019-08-27 12:28:27 +02:00 (Migrated from github.com)
Review

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8
import os
import unittest
from src.pyelliptic.eccblind import ECCBlind
g1itch commented 2019-08-27 11:09:52 +02:00 (Migrated from github.com)
Review

Shebang is not needed here.

Shebang is not needed here.
g1itch commented 2019-08-27 11:15:09 +02:00 (Migrated from github.com)
Review

from pybitmessage.pyelliptic.eccblind import ECCBlind

`from pybitmessage.pyelliptic.eccblind import ECCBlind`
g1itch commented 2019-08-27 11:16:07 +02:00 (Migrated from github.com)
Review

self.assertTrue(blind_sig.verify())

`self.assertTrue(blind_sig.verify())`
g1itch commented 2019-08-27 11:19:42 +02:00 (Migrated from github.com)
Review

If you write docstring in one line it will be shown in the test results. e.g.

    def test_blind_sig(self):
        """Test full sequence using a random certifier key and a random msg"""
If you write docstring in one line it will be shown in the test results. e.g. ```python def test_blind_sig(self): """Test full sequence using a random certifier key and a random msg""" ```
PeterSurda commented 2019-08-27 12:25:00 +02:00 (Migrated from github.com)
Review

This breaks the test.

This breaks the test.
g1itch commented 2019-08-27 12:27:08 +02:00 (Migrated from github.com)
Review

It depends on how you run it.

It depends on how you run it.
g1itch commented 2019-08-27 12:28:27 +02:00 (Migrated from github.com)
Review

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8
from pybitmessage.pyelliptic.eccblind import ECCBlind
g1itch commented 2019-08-27 11:09:52 +02:00 (Migrated from github.com)
Review

Shebang is not needed here.

Shebang is not needed here.
g1itch commented 2019-08-27 11:15:09 +02:00 (Migrated from github.com)
Review

from pybitmessage.pyelliptic.eccblind import ECCBlind

`from pybitmessage.pyelliptic.eccblind import ECCBlind`
g1itch commented 2019-08-27 11:16:07 +02:00 (Migrated from github.com)
Review

self.assertTrue(blind_sig.verify())

`self.assertTrue(blind_sig.verify())`
g1itch commented 2019-08-27 11:19:42 +02:00 (Migrated from github.com)
Review

If you write docstring in one line it will be shown in the test results. e.g.

    def test_blind_sig(self):
        """Test full sequence using a random certifier key and a random msg"""
If you write docstring in one line it will be shown in the test results. e.g. ```python def test_blind_sig(self): """Test full sequence using a random certifier key and a random msg""" ```
PeterSurda commented 2019-08-27 12:25:00 +02:00 (Migrated from github.com)
Review

This breaks the test.

This breaks the test.
g1itch commented 2019-08-27 12:27:08 +02:00 (Migrated from github.com)
Review

It depends on how you run it.

It depends on how you run it.
g1itch commented 2019-08-27 12:28:27 +02:00 (Migrated from github.com)
Review

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8
class TestBlindSig(unittest.TestCase):

g1itch commented 2019-08-27 11:09:52 +02:00 (Migrated from github.com)
Review

Shebang is not needed here.

Shebang is not needed here.
g1itch commented 2019-08-27 11:09:52 +02:00 (Migrated from github.com)
Review

Shebang is not needed here.

Shebang is not needed here.
g1itch commented 2019-08-27 11:15:09 +02:00 (Migrated from github.com)
Review

from pybitmessage.pyelliptic.eccblind import ECCBlind

`from pybitmessage.pyelliptic.eccblind import ECCBlind`
g1itch commented 2019-08-27 11:15:09 +02:00 (Migrated from github.com)
Review

from pybitmessage.pyelliptic.eccblind import ECCBlind

`from pybitmessage.pyelliptic.eccblind import ECCBlind`
g1itch commented 2019-08-27 11:16:07 +02:00 (Migrated from github.com)
Review

self.assertTrue(blind_sig.verify())

`self.assertTrue(blind_sig.verify())`
g1itch commented 2019-08-27 11:16:07 +02:00 (Migrated from github.com)
Review

self.assertTrue(blind_sig.verify())

`self.assertTrue(blind_sig.verify())`
g1itch commented 2019-08-27 11:19:42 +02:00 (Migrated from github.com)
Review

If you write docstring in one line it will be shown in the test results. e.g.

    def test_blind_sig(self):
        """Test full sequence using a random certifier key and a random msg"""
If you write docstring in one line it will be shown in the test results. e.g. ```python def test_blind_sig(self): """Test full sequence using a random certifier key and a random msg""" ```
g1itch commented 2019-08-27 11:19:42 +02:00 (Migrated from github.com)
Review

If you write docstring in one line it will be shown in the test results. e.g.

    def test_blind_sig(self):
        """Test full sequence using a random certifier key and a random msg"""
If you write docstring in one line it will be shown in the test results. e.g. ```python def test_blind_sig(self): """Test full sequence using a random certifier key and a random msg""" ```
PeterSurda commented 2019-08-27 12:25:00 +02:00 (Migrated from github.com)
Review

This breaks the test.

This breaks the test.
PeterSurda commented 2019-08-27 12:25:00 +02:00 (Migrated from github.com)
Review

This breaks the test.

This breaks the test.
g1itch commented 2019-08-27 12:27:08 +02:00 (Migrated from github.com)
Review

It depends on how you run it.

It depends on how you run it.
g1itch commented 2019-08-27 12:27:08 +02:00 (Migrated from github.com)
Review

It depends on how you run it.

It depends on how you run it.
g1itch commented 2019-08-27 12:28:27 +02:00 (Migrated from github.com)
Review

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8
g1itch commented 2019-08-27 12:28:27 +02:00 (Migrated from github.com)
Review

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8

Travis CI should be OK, because I used such imports before: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L8