New POW calculation module #1284

Open
Kleshni wants to merge 38 commits from Kleshni/POW into v0.6
2 changed files with 3 additions and 4 deletions
Showing only changes of commit 7ad1725235 - Show all commits

View File

@ -271,15 +271,14 @@ def setBestSolver():
setBestSolver()
class singleWorker(threading.Thread, helper_threading.StoppableThread):
name = "singleWorker"
def __init__(self):
super(self.__class__, self).__init__()
super(self.__class__, self).__init__(name = "singleWorker")
self.initStop()
def stopThread(self):
queues.workerQueue.put(("stopThread", "data"))
workProver.commandsQueue.put(("shutdown", ))
super(self.__class__, self).stopThread()

View File

@ -119,7 +119,7 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.solverName = name
self.solver = self.availableSolvers[name]
self.solver.setConfiguration(configuration)
except GPUSolverError:
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
except gpusolver.GPUSolverError:
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.solverName = None
self.solver = None

omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'