New POW calculation module #1284

Open
Kleshni wants to merge 38 commits from Kleshni/POW into v0.6
7 changed files with 21 additions and 21 deletions
Showing only changes of commit 917b55d463 - Show all commits

View File

@ -1,16 +1,16 @@
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import sys
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import multiprocessing
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import time
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import struct
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import threading
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import Queue
omkar1117 commented 2018-07-25 06:07:41 +02:00 (Migrated from github.com)
Review

please place all the imports in a alphabetic order.

please place all the imports in a alphabetic order.
import collections
import multiprocessing
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import struct
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import sys
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import threading
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import time
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import utils
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import dumbsolver
import forkingsolver
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import fastsolver
import forkingsolver
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
import gpusolver
import utils
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
timeout = .5

omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'

View File

@ -1,6 +1,6 @@
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
import ctypes
import struct
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
import hashlib
import struct
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
import utils

omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.

View File

@ -1,8 +1,8 @@
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
import sys
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
import ctypes
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
import os.path
import platform
import subprocess
import ctypes
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
import sys
omkar1117 commented 2018-06-23 11:58:39 +02:00 (Migrated from github.com)
Review

please write all the imports in alphabetic order

please write all the imports in alphabetic order
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
class FastSolverError(Exception):
pass

omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here

View File

@ -1,5 +1,5 @@
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
import os
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
import multiprocessing
import os
omkar1117 commented 2018-06-23 12:02:19 +02:00 (Migrated from github.com)
Review

pep8 validation for the file

pep8 validation for the file
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
import struct
import dumbsolver

omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces

View File

@ -1,6 +1,6 @@
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
import hashlib
import struct
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
import os.path
import struct
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
import utils
@ -15,8 +15,8 @@ class GPUSolver(object):
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
global pyopencl, numpy
try:
import pyopencl
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
import numpy
import pyopencl
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
except ImportError:
raise GPUSolverError()

g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?

View File

@ -1,19 +1,19 @@
#!/usr/bin/env python2.7
import unittest
import os.path
import binascii
import struct
import ctypes
import ctypes.util
import os.path
import struct
import sys
import unittest
import __init__
import utils
import dumbsolver
import forkingsolver
import fastsolver
import forkingsolver
import gpusolver
import utils
codePath = os.path.dirname(__file__)

View File

@ -1,9 +1,9 @@
import hashlib
import struct
import time
import math
import sys
import os
import struct
import sys
import time
def calculateInitialHash(initialPayload):
return hashlib.sha512(initialPayload).digest()