From 135715905f4a86525ff4ee71cd0eca59edfdd89b Mon Sep 17 00:00:00 2001 From: "kuldeep.k@cisinlabs.com" Date: Fri, 20 Aug 2021 22:04:28 +0530 Subject: [PATCH 1/3] Updated code quality class doc string, import ignore & comment spaces in setup.py --- setup.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/setup.py b/setup.py index 77ec81c8..ed3d4705 100644 --- a/setup.py +++ b/setup.py @@ -27,6 +27,8 @@ EXTRAS_REQUIRE = { class InstallCmd(install): + '''Install cmd''' + def run(self): # prepare icons directories try: @@ -84,7 +86,7 @@ if __name__ == "__main__": "msgpack-python" if msgpack.version[:2] < (0, 6) else "msgpack") except ImportError: try: - import umsgpack + import umsgpack # noqa:F401 installRequires.append("umsgpack") except ImportError: packages += ['pybitmessage.fallback.umsgpack'] @@ -115,11 +117,11 @@ if __name__ == "__main__": long_description=README, license='MIT', # TODO: add author info - #author='', - #author_email='', + # author='', + # author_email='', url='https://bitmessage.org', # TODO: add keywords - #keywords='', + # keywords='', install_requires=installRequires, tests_require=requirements, test_suite='tests.unittest_discover', -- 2.45.1 From e82e97cb2b279b0f3e086746d6c9a371157331c9 Mon Sep 17 00:00:00 2001 From: "kuldeep.k@cisinlabs.com" Date: Fri, 27 Aug 2021 18:53:59 +0530 Subject: [PATCH 2/3] Updated InstallCmd docstring & replaced unused import ignore warning by importlib import_module function --- setup.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index ed3d4705..9f6a16ca 100644 --- a/setup.py +++ b/setup.py @@ -5,6 +5,7 @@ import platform import shutil import sys +from importlib import import_module from setuptools import setup, Extension from setuptools.command.install import install @@ -27,7 +28,7 @@ EXTRAS_REQUIRE = { class InstallCmd(install): - '''Install cmd''' + """Custom setuptools install command preparing icons""" def run(self): # prepare icons directories @@ -86,7 +87,7 @@ if __name__ == "__main__": "msgpack-python" if msgpack.version[:2] < (0, 6) else "msgpack") except ImportError: try: - import umsgpack # noqa:F401 + import_module('umsgpack') installRequires.append("umsgpack") except ImportError: packages += ['pybitmessage.fallback.umsgpack'] -- 2.45.1 From 72bcbdf4c9c7edac9c1d79ad1c4de9f2b9c0f158 Mon Sep 17 00:00:00 2001 From: "kuldeep.k@cisinlabs.com" Date: Tue, 31 Aug 2021 22:32:33 +0530 Subject: [PATCH 3/3] Removed some kwargs comments --- setup.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/setup.py b/setup.py index 9f6a16ca..7b4821d7 100644 --- a/setup.py +++ b/setup.py @@ -118,11 +118,8 @@ if __name__ == "__main__": long_description=README, license='MIT', # TODO: add author info - # author='', - # author_email='', url='https://bitmessage.org', # TODO: add keywords - # keywords='', install_requires=installRequires, tests_require=requirements, test_suite='tests.unittest_discover', -- 2.45.1