qrcode plugin fixes #1153

2018-03-12T11:08:38+01:00

g1itch commented

2018-03-12 11:08:38 +01:00

(Migrated from github.com)

Hello.

This is my technical debt on qrcode plugin:

all unused code removed;
menu entry is shown on any QTreeWidgetItem with address;
such plugins now have prefix address.;
'BM:' is a schema for QR-code now.

Should I make that plugins also available for Address book and Blacklist entries?

Hello. This is my technical debt on qrcode plugin: - all unused code removed; - menu entry is shown on any `QTreeWidgetItem` with address; - such plugins now have prefix `address.`; - 'BM:' is a schema for QR-code now. Should I make that plugins also available for Address book and Blacklist entries?

PeterSurda commented

2018-03-13 11:06:13 +01:00

(Migrated from github.com)

Can look at the codacy review and add docstrings? Don't worry about the "name doesn't conform", I'll try to adjust the check so that it doesn't complain.

PeterSurda commented

2018-03-13 14:55:57 +01:00

(Migrated from github.com)

I changed the method and function naming regexp, let's see if it is better now.

PeterSurda commented

2018-03-13 15:11:41 +01:00

(Migrated from github.com)

Maybe it takes a while for the changes to kick in.

PeterSurda (Migrated from github.com) reviewed 2018-03-14 07:31:57 +01:00

src/plugins/menu_qrcode.py

						
				@ -0,0 +66,4 @@

				        self.label.setText(text)

				        self.image.setPixmap(

				            qrcode.make(text, image_factory=Image).pixmap())

				        self.setFixedSize(QtGui.QWidget.sizeHint(self))