Bitmessage/PyBitmessage-2024-12-11
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Code quality #1773

Open
PeterSurda wants to merge 1 commits from PeterSurda/cq101 into v0.6
pull from: PeterSurda/cq101
merge into: Bitmessage:v0.6
Conversation 0 Commits 1 Files Changed 2 +10 -2
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/tls.py
View File

@ -44,7 +44,7 @@ else:
class TLSDispatcher(AdvancedDispatcher): class TLSDispatcher(AdvancedDispatcher):
"""TLS functionality for classes derived from AdvancedDispatcher""" """TLS functionality for classes derived from AdvancedDispatcher"""
# pylint: disable=too-many-instance-attributes, too-many-arguments # pylint: disable=too-many-instance-attributes, too-many-arguments
# pylint: disable=super-init-not-called # pylint: disable=super-init-not-called, unused-argument
def __init__(self, _=None, sock=None, certfile=None, keyfile=None, def __init__(self, _=None, sock=None, certfile=None, keyfile=None,
server_side=False, ciphers=sslProtocolCiphers): server_side=False, ciphers=sslProtocolCiphers):
self.want_read = self.want_write = True self.want_read = self.want_write = True

10
src/network/udp.py
View File

@ -21,7 +21,7 @@ class UDPSocket(BMProto): # pylint: disable=too-many-instance-attributes
port = 8444 port = 8444
def __init__(self, host=None, sock=None, announcing=False): def __init__(self, host=None, sock=None, announcing=False):
# pylint: disable=bad-super-call # pylint: disable=bad-super-call, access-member-before-definition
super(BMProto, self).__init__(sock=sock) super(BMProto, self).__init__(sock=sock)
g1itch commented 2021-08-09 11:26:10 +02:00 (Migrated from github.com)
Review
Copy Link

This is a bug: https://github.com/PyCQA/pylint/issues/2315

This is a bug: https://github.com/PyCQA/pylint/issues/2315
Jeroenvb3 commented 2022-12-21 11:12:00 +01:00 (Migrated from github.com)
Review
Copy Link

The linked bug has been fixed. The ignore shouldn't be needed anymore.

The linked bug has been fixed. The ignore shouldn't be needed anymore.
self.verackReceived = True self.verackReceived = True
g1itch commented 2021-06-02 14:55:36 +02:00 (Migrated from github.com)
Review
Copy Link
super(UDPSocket, self).__init__(sock=sock)

?

```python super(UDPSocket, self).__init__(sock=sock) ``` ?
self.verackSent = True self.verackSent = True
@ -97,22 +97,30 @@ class UDPSocket(BMProto): # pylint: disable=too-many-instance-attributes
time.time() time.time()
return True return True
# override the protocol do ignore the following commands on UDP
# we do this mainly for security reasons
def bm_command_portcheck(self): def bm_command_portcheck(self):
# pylint: disable=no-self-use
return True return True
def bm_command_ping(self): def bm_command_ping(self):
# pylint: disable=no-self-use
return True return True
def bm_command_pong(self): def bm_command_pong(self):
g1itch commented 2021-08-09 11:19:15 +02:00 (Migrated from github.com)
Review
Copy Link

This is more of inheritance flow. Maybe UDPSocket should inherit from some more basic class?

This is more of inheritance flow. Maybe `UDPSocket` should inherit from some more basic class?
PeterSurda commented 2021-08-09 12:27:09 +02:00 (Migrated from github.com)
Review
Copy Link

Perhaps.

Perhaps.
# pylint: disable=no-self-use
return True return True
def bm_command_verack(self): def bm_command_verack(self):
# pylint: disable=no-self-use
return True return True
def bm_command_version(self): def bm_command_version(self):
# pylint: disable=no-self-use
return True return True
def handle_connect(self): def handle_connect(self):
# pylint: disable=no-self-use
return return
def writable(self): def writable(self):