A Gentle Reminder to All Bitmessage Developers !!! #527

New Issue

2013-10-15T12:07:08+02:00

Arnukk commented

2013-10-15 12:07:08 +02:00

(Migrated from github.com)

Dear colleagues,

In order to make the Bitmessage code scalable and flexible in terms of making changes/adding features please use non-static references to objects.
For example I found all over the code statements like this:

self.ui.tabWidget.setTabText(6, 'Whitelist')

Instead it should be:

self.ui.tabWidget.setTabText(self.ui.tabWidget.indexOf(self.ui.blackwhitelist), 'Whitelist')

Otherwise, if you add a tab somewhere in between the existing tabs it will mess up everything.

Thanks !
Arnukk

Dear colleagues, In order to make the Bitmessage code scalable and flexible in terms of making changes/adding features please use non-static references to objects. For example I found all over the code statements like this: <b>self.ui.tabWidget.setTabText(6, 'Whitelist')</b> Instead it should be: <b> self.ui.tabWidget.setTabText(self.ui.tabWidget.indexOf(self.ui.blackwhitelist), 'Whitelist') </b> Otherwise, if you add a tab somewhere in between the existing tabs it will mess up everything. Thanks ! Arnukk

Atheros1 commented

2013-10-16 05:51:29 +02:00

(Migrated from github.com)

Wise advice. Thank you.

Arnukk commented

2013-10-16 16:00:57 +02:00

(Migrated from github.com)

You are welcome :)

PeterSurda commented

2015-10-18 12:27:00 +02:00

(Migrated from github.com)

I will review this.

PeterSurda commented

2016-04-28 15:16:11 +02:00

(Migrated from github.com)

I see there are plenty of places where it is like that, but I'm postponing it for 0.8 milestone because it's not an urgent issue. On some spots, me or other developers did fix it (@mirrorwish refactored some interfaces, I refactored the language selection combo box, that one was ugly).

This repo is archived. You cannot comment on issues.