Bitmessage/PyBitmessage-2024-12-13
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Updated code quality removed print statement spaces in singleinstance.py #1833

Merged
kdcis merged 4 commits from v0.6-codequality-singleinstance into v0.6 2021-10-01 14:03:06 +02:00
Conversation 1 Commits 4 Files Changed 1 +7 -9
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/singleinstance.py
View File

@ -55,12 +55,9 @@ class singleinstance(object):
) )
except OSError as e: except OSError as e:
if e.errno == 13: if e.errno == 13:
print( sys.exit(
'Another instance of this application' 'Another instance of this application is'
' is already running' ' already running')
)
sys.exit(-1)
print(e.errno)
raise raise
else: else:
pidLine = "%i\n" % self.lockPid pidLine = "%i\n" % self.lockPid
@ -75,8 +72,9 @@ class singleinstance(object):
fcntl.lockf(self.fp, fcntl.LOCK_EX | fcntl.LOCK_NB) fcntl.lockf(self.fp, fcntl.LOCK_EX | fcntl.LOCK_NB)
self.lockPid = os.getpid() self.lockPid = os.getpid()
except IOError: except IOError:
g1itch commented 2021-08-31 16:41:43 +02:00 (Migrated from github.com)
Review
Copy Link

sys.exit('Another instance of this application is already running')

`sys.exit('Another instance of this application is already running')`
g1itch commented 2021-08-31 16:46:34 +02:00 (Migrated from github.com)
Review
Copy Link

And the same above. print(e.errno) is also redundant as for me.

And the same above. `print(e.errno)` is also redundant as for me.
kdcis commented 2021-09-02 13:46:11 +02:00 (Migrated from github.com)
Review
Copy Link

Updated

Updated
print ('Another instance of this application is already running') sys.exit(
sys.exit(-1) 'Another instance of this application is'
' already running')
else: else:
pidLine = "%i\n" % self.lockPid pidLine = "%i\n" % self.lockPid
self.fp.truncate(0) self.fp.truncate(0)
@ -99,7 +97,7 @@ class singleinstance(object):
pass pass
return return
print ("Cleaning up lockfile")
try: try:
if sys.platform == 'win32': if sys.platform == 'win32':
if hasattr(self, 'fd'): if hasattr(self, 'fd'):