Changes based on style and lint checks. (final_code_quality_6) #1364

2018-10-10T12:46:12+02:00

coffeedogs commented

2018-10-10 12:46:12 +02:00

(Migrated from github.com)

Changes based on style and lint checks. (final_code_quality_6)

PeterSurda (Migrated from github.com) reviewed 2018-10-12 09:41:47 +02:00

src/api.py

PeterSurda (Migrated from github.com) commented

2018-10-12 09:41:47 +02:00

@coffeedogs This print should be removed, as well as other prints in this file, however this is a separate task so I created a new issue and assigned it to you.

PeterSurda (Migrated from github.com) approved these changes 2018-10-12 09:43:19 +02:00

PeterSurda (Migrated from github.com) approved these changes 2018-10-14 18:04:39 +02:00

PeterSurda commented

2018-10-14 18:10:22 +02:00

(Migrated from github.com)

I think the commit isn't signed, other than that it's ready to go.

coffeedogs commented

2018-10-18 20:51:37 +02:00

(Migrated from github.com)

Guessing that wasn't signed since I only had a project-level enforce set in git config and was using a separate directory to do this rebasing. I've now set git's enforced signing to be global, thanks for the vigilance!

PeterSurda commented

2018-10-20 16:27:09 +02:00

(Migrated from github.com)

Oh you can merge it yourself as long as all the required conditions pass, that's cool, I didn't know that.

This repo is archived. You cannot comment on pull requests.

No reviewers

PeterSurda