tests for BMConfigParser._reset #1754

Closed
opened 2021-04-27 10:09:57 +02:00 by PeterSurda · 3 comments
PeterSurda commented 2021-04-27 10:09:57 +02:00 (Migrated from github.com)

Write tests and re-enable in Python 3

Write tests and re-enable in Python 3
kdcis commented 2021-05-28 14:22:37 +02:00 (Migrated from github.com)

Hi @PeterSurda
You can close this issue. I've raised a PR for this, Please check #1766

Hi @PeterSurda You can close this issue. I've raised a PR for this, Please check #1766
g1itch commented 2021-05-28 14:40:40 +02:00 (Migrated from github.com)

Hi @PeterSurda
You can close this issue. I've raised a PR for this, Please check #1766

Excuse me, but it works in other way: when the tests for python3 pass you write in the last commit message something like "Fixes: #1754" and this issue will be closed by PR merge.

> Hi @PeterSurda > You can close this issue. I've raised a PR for this, Please check #1766 Excuse me, but it works in other way: when the tests for python3 pass you write in the last commit message something like ["Fixes: #1754"](https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-issues/linking-a-pull-request-to-an-issue) and this issue will be closed by PR merge.
kdcis commented 2021-05-28 16:11:02 +02:00 (Migrated from github.com)

Okay, Got it. Will do that.
Edit: Done

Okay, Got it. Will do that. Edit: Done
This repo is archived. You cannot comment on issues.
No Milestone
No project
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-14#1754
No description provided.