API clientStatus bug #1383

New Issue

2018-11-01T11:42:32+01:00

PeterSurda commented

2018-11-01 11:42:32 +01:00

(Migrated from github.com)

came over BM. I haven't tested it, just crosspasting

In their infinite wisdom the devs have decided on the following logic:
If currently connected networkStatus is 'notConnected'
If not currently connected and have not received any incoming connections. networkStatus is "connectedButHaveNotReceivedIncomingConnections"
Otherwise networkStatus is "connectedAndReceivingIncomingConnections"

Hmm well for me it's been working fine until just recently.

in --curses it never worked even be4

I've been running a headless BM instance for a while and I use the api.clientStatus call to monitor it. I noticed that the networkStatus field says "notConnected" when it's connected and receiving incoming connections.
I don't know if this was today's pull or the one before that introduced it.

**came over BM. I haven't tested it, just crosspasting** ------------------------------------------------------ In their infinite wisdom the devs have decided on the following logic: If currently connected networkStatus is 'notConnected' If not currently connected and have not received any incoming connections. networkStatus is "connectedButHaveNotReceivedIncomingConnections" Otherwise networkStatus is "connectedAndReceivingIncomingConnections" ------------------------------------------------------- Hmm well for me it's been working fine until just recently. ------------------------------------------------------ in --curses it never worked even be4 ------------------------------------------------------ I've been running a headless BM instance for a while and I use the api.clientStatus call to monitor it. I noticed that the networkStatus field says "notConnected" when it's connected and receiving incoming connections. I don't know if this was today's pull or the one before that introduced it.

g1itch commented

2018-11-01 14:03:34 +01:00

(Migrated from github.com)

Yes, it looks strange. Introduced in 7ed459b.
Previous edition was:

if len(network.stats.connectedHostsList()) == 0:
    networkStatus = 'notConnected'

Yes, it [looks strange](../blob/v0.6/src/api.py#L1331). Introduced in 7ed459b. Previous edition was: ```python if len(network.stats.connectedHostsList()) == 0: networkStatus = 'notConnected' ```

This repo is archived. You cannot comment on issues.