New POW calculation module #1284

Open
Kleshni wants to merge 38 commits from Kleshni/POW into v0.6
4 changed files with 30 additions and 13 deletions
Showing only changes of commit 2c7d677ccf - Show all commits

View File

@ -54,6 +54,7 @@ from network.asyncore_pollchoose import set_rates
import sound
import re
import bitmessage_icons_rc # Loads icon resources
import workprover.utils
try:
@ -1876,11 +1877,17 @@ class MyForm(settingsmixin.SMainWindow):
if status.speed == 0:
self.ui.workProverSpeed.setText("")
self.ui.workProverSpeed.setToolTip("")
else:
self.ui.workProverSpeed.setText(
_translate("MainWindow", "%1 kiH / s").arg("{:.1f}".format(status.speed / 1024))
)
self.ui.workProverSpeed.setToolTip("Difficulty: {}, 80 % completion time: {:.1f} s".format(
status.difficulty,
workprover.utils.estimateMaximumIterationsCount(status.difficulty, .8) / status.speed
))
def rerenderMessagelistFromLabels(self):
for messagelist in (self.ui.tableWidgetInbox, self.ui.tableWidgetInboxChans, self.ui.tableWidgetInboxSubscriptions):
for i in range(messagelist.rowCount()):

View File

@ -21,13 +21,14 @@ class Task(object):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
previous = None
next = None
def __init__(self, headlessPayload, TTL, expiryTime, target):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
def __init__(self, headlessPayload, TTL, expiryTime, target, difficulty):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.headlessPayload = headlessPayload
self.TTL = TTL
self.expiryTime = expiryTime
self.target = target
self.difficulty = difficulty
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
Status = collections.namedtuple("Status", ["solverName", "solverStatus", "speed", "tasksCount"])
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
Status = collections.namedtuple("Status", ["solverName", "solverStatus", "speed", "tasksCount", "difficulty"])
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
class WorkProver(threading.Thread):
# Seed must be 32 bytes
@ -81,6 +82,7 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.lastTime = utils.getTimePoint()
self.timedIntervals = collections.deque()
self.speed = 0
self.totalDifficulty = 0
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.tasks = {}
self.currentTaskID = None
@ -94,7 +96,7 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
if self.solver is not None:
status = self.solver.status
self.statusUpdated(Status(self.solverName, status, self.speed, len(self.tasks)))
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.statusUpdated(Status(self.solverName, status, self.speed, len(self.tasks), self.totalDifficulty))
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
def setSolver(self, name, configuration):
if name is None and self.solverName is None:
@ -145,11 +147,12 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.notifyStatus()
def addTask(self, ID, headlessPayload, TTL, expiryTime, byteDifficulty, lengthExtension):
target = utils.calculateTarget(8 + 8 + len(headlessPayload), TTL, byteDifficulty, lengthExtension)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
target, difficulty = utils.calculateTarget(8 + 8 + len(headlessPayload), TTL, byteDifficulty, lengthExtension)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
task = Task(headlessPayload, TTL, expiryTime, target)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
task = Task(headlessPayload, TTL, expiryTime, target, difficulty)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.tasks[ID] = task
self.totalDifficulty += difficulty
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
if self.currentTaskID is None:
omkar1117 commented 2018-06-23 11:33:56 +02:00 (Migrated from github.com)
Review

add docs to the function.

add docs to the function.
task.previous = ID
@ -163,11 +166,14 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.tasks[task.previous].next = ID
self.tasks[task.next].previous = ID
self.notifyStatus()
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
def cancelTask(self, ID):
if ID not in self.tasks:
return
task = self.tasks.pop(ID)
self.totalDifficulty -= task.difficulty
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
if len(self.tasks) == 0:
self.currentTaskID = None
@ -178,6 +184,8 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
if self.currentTaskID == ID:
self.currentTaskID = task.next
self.notifyStatus()
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
def nextTask(self):
self.currentTaskID = self.tasks[self.currentTaskID].next

omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'

View File

@ -44,6 +44,7 @@ byteDifficulty = 1000
lengthExtension = 1000
target = 0x00000f903320b7f6
difficulty = 1078000
seed = binascii.unhexlify("3941c24a1256660a8f65d962954c406dab7bc449317fa087c4a3f1a3ca7d95fd")
timeout = .5
@ -56,8 +57,8 @@ class TestUtils(unittest.TestCase):
self.assertEqual(utils.calculateDoubleHash(payload), doubleHash)
def testCalculateTarget(self):
self.assertEqual(utils.calculateTarget(1000, 1015, 1000, 1000), 0x00000843bf57fed2)
self.assertEqual(utils.calculateTarget(1000, 1016, 1000, 1000), 0x00000842b4a960c2)
self.assertEqual(utils.calculateTarget(1000, 1015, 1000, 1000), (0x00000843bf57fed2, 2030000))
self.assertEqual(utils.calculateTarget(1000, 1016, 1000, 1000), (0x00000842b4a960c2, 2031000))
def testCheckProof(self):
self.assertFalse(utils.checkProof(nonce, initialHash, 0x000002fe91eba355))
@ -75,8 +76,8 @@ class TestUtils(unittest.TestCase):
utils.time.time = originalTime
def testEstimateMaximumIterationsCount(self):
self.assertEqual(utils.estimateMaximumIterationsCount(0x000fffffffffffff, .1), 512)
self.assertEqual(utils.estimateMaximumIterationsCount(target, .8), 1735168)
self.assertEqual(utils.estimateMaximumIterationsCount(4096, .1), 512)
self.assertEqual(utils.estimateMaximumIterationsCount(difficulty, .8), 1735168)
class TestSolver(unittest.TestCase):
def setUp(self):
@ -135,6 +136,8 @@ class TestWorkProver(unittest.TestCase):
linkID = next(iter(IDs))
for i in xrange(len(IDs)):
self.assertGreaterEqual(self.thread.totalDifficulty, 0)
self.assertIn(linkID, IDs)
IDs.remove(linkID)

View File

@ -19,7 +19,7 @@ def calculateTarget(length, TTL, byteDifficulty, lengthExtension):
difficulty = byteDifficulty * (adjustedLength + timeEquivalent)
return 2 ** 64 / difficulty
return 2 ** 64 / difficulty, difficulty
def checkProof(nonce, initialHash, target):
proof = nonce + initialHash
@ -34,13 +34,12 @@ def checkWorkSufficient(payload, byteDifficulty, lengthExtension):
nonce = payload[: 8]
initialHash = calculateInitialHash(payload[8: ])
target = calculateTarget(len(payload), minimumTTL, byteDifficulty, lengthExtension)
target, difficulty = calculateTarget(len(payload), minimumTTL, byteDifficulty, lengthExtension)
return checkProof(nonce, initialHash, target)
def estimateMaximumIterationsCount(target, probability):
def estimateMaximumIterationsCount(difficulty, probability):
coefficient = -math.log(1 - probability)
difficulty = 2. ** 64 / target
return int(coefficient * difficulty + 255) / 256 * 256