asyncore_pollchoose import refactor #1381

New Issue

2018-10-31T14:44:18+01:00

coffeedogs commented

2018-10-31 14:44:18 +01:00

(Migrated from github.com)

src/network/asyncore_pollchoose.py could benefit from changes like this to imports, however it would imply importing errno directly which would require some refactoring of the file which is out of scope for the code_quality work which is already approved. This change was recommended by @g1itch

This issue is to ensure such refactoring is considered at some point.

src/network/asyncore_pollchoose.py could benefit from [changes like this](https://github.com/Bitmessage/PyBitmessage/commit/533df80ce98c40b0a2424ecc17bd395e0dbcdfa7) to imports, however it would imply importing errno directly which would require some refactoring of the file which is out of scope for the code_quality work which is already approved. This change was recommended by @g1itch This issue is to ensure such refactoring is considered at some point.

g1itch commented

2018-10-31 15:35:34 +01:00

(Migrated from github.com)

You can also use importlib to fool the lints, like here.

You can also use `importlib` to fool the lints, like [here](../blob/v0.6/src/depends.py#L152).

PeterSurda commented

2018-10-31 17:19:54 +01:00

(Migrated from github.com)

This is based on code which is originally included in python 2.7, someone patched it to add epoll and kqueue support and I made further changes.

I don't remember exactly whether I added winsock handling fully, or just amended it based on my tests. I don't mind if it's changed, but it would need further testing and now's not the time for that.

This is based on code which is originally included in python 2.7, someone patched it to add epoll and kqueue support and I made further changes. I don't remember exactly whether I added winsock handling fully, or just amended it based on my tests. I don't mind if it's changed, but it would need further testing and now's not the time for that.

This repo is archived. You cannot comment on issues.