Bug fix: Conversion from QString to standard string #223

2013-06-19T12:30:36+02:00

ghost commented

2013-06-19 12:30:36 +02:00

(Migrated from github.com)

No description provided.

Atheros1 commented

2013-06-20 13:18:51 +02:00

(Migrated from github.com)

I believe that str() will fail if given international characters. The following works for the normal tray notification. Does it work for the Notify.Notification menu?

self.notifierShow('Bitmessage', unicode(_translate("MainWindow", "Connected").toUtf8(),'utf-8'))

I believe that str() will fail if given international characters. The following works for the normal tray notification. Does it work for the Notify.Notification menu? ``` self.notifierShow('Bitmessage', unicode(_translate("MainWindow", "Connected").toUtf8(),'utf-8')) ```

ghost commented

2013-06-20 13:24:40 +02:00

(Migrated from github.com)

Traceback (most recent call last):
File "/usr/share/pybitmessage/bitmessageqt/init.py", line 895, in updateNetworkStatusTab
self.setStatusIcon('yellow')
File "/usr/share/pybitmessage/bitmessageqt/init.py", line 925, in setStatusIcon
unicode(_translate("MainWindow","Connected").toUtf8(),'utf-8'))
NameError: global name '_translate' is not defined

Traceback (most recent call last): File "/usr/share/pybitmessage/bitmessageqt/**init**.py", line 895, in updateNetworkStatusTab self.setStatusIcon('yellow') File "/usr/share/pybitmessage/bitmessageqt/**init**.py", line 925, in setStatusIcon unicode(_translate("MainWindow","Connected").toUtf8(),'utf-8')) NameError: global name '_translate' is not defined

Atheros1 commented

2013-06-20 13:30:26 +02:00

(Migrated from github.com)

Oh, pardon me. I'm working off of the latest code.
This doesn't use _translate :
self.notifierShow('Bitmessage', unicode(QtGui.QApplication.translate"MainWindow", "Connected").toUtf8(),'utf-8'))

Oh, pardon me. I'm working off of the latest code. This doesn't use _translate : self.notifierShow('Bitmessage', unicode(QtGui.QApplication.translate"MainWindow", "Connected").toUtf8(),'utf-8'))

ghost commented

2013-06-20 13:39:31 +02:00

(Migrated from github.com)

Yes that works.

Atheros1 commented

2013-06-20 22:44:39 +02:00

(Migrated from github.com)

Merged. Tested normal notifications: successful. You may still want to test the messaging menu. I added the "translate" functions to the 'New Message' notification; it was missed previously.
Thank you

Merged. Tested normal notifications: successful. You may still want to test the messaging menu. I added the "translate" functions to the 'New Message' notification; it was missed previously. Thank you

This repo is archived. You cannot comment on pull requests.

No reviewers