Add onlynet=onion config option #1538

New Issue

2019-10-06T16:23:35+02:00

gousasin commented

2019-10-06 16:23:35 +02:00

(Migrated from github.com)

Please add an onlynet=onion configuration option like in Bitcoin Core to exclusively allow connections to Bitmessage nodes behind a Tor Onion Service for enhanced privacy at the network layer.

sgj3 commented

2019-10-28 08:53:46 +01:00

(Migrated from github.com)

Implemented by PR #1545.

g1itch commented

2019-10-28 09:00:51 +01:00

(Migrated from github.com)

Implemented by PR #1545.

Close but not exact implementation. In the future PR's consider to put closes # in the commit message.

> Implemented by PR #1545. Close but not exact implementation. In the future PR's consider to put [closes #](https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords) in the commit message.

sgj3 commented

2020-02-14 05:16:04 +01:00

(Migrated from github.com)

So, do you want this refactored to use literally "onlynet=onion"?

gousasin commented

2020-02-14 12:51:23 +01:00

(Migrated from github.com)

I don't really care about the syntax if the functionality is implemented. "onlynet=onion" is used by Bitcoin so I just copied it from there. I leave it up to you.

sgj3 commented

2020-02-15 05:41:46 +01:00

(Migrated from github.com)

OK, understood.

@g1itch What do you think? You left it open and assigned the refactoring label. Is this is what you had in mind?

OK, understood. @g1itch What do you think? You left it open and assigned the `refactoring` label. Is this is what you had in mind?

sgj3 commented

2020-03-15 06:09:08 +01:00

(Migrated from github.com)

@g1itch Bump

g1itch commented

2020-10-05 17:19:41 +02:00

(Migrated from github.com)

Besides the refactoring there is a new complaint from chan:

If onionservicesonly is enabled and there are no available onion bootstrap servers PyBitmessage will never connect to the network without connecting to bootstrapXXXX.

When onionservicesonly is enabled, the user expects PyBitmessage not to connect non-onion nodes at all.
So if onion bootstrap nodes are not to be connected, PyBitmessage should stop bootstrapping and show error message.
The user then decides not to use PyBitmessage for a while or to change his policy to connet to non-onion nodes.
Security policy is more important than connectivity.
...

If onionservicesonly is enabled and there are no available onion bootstrap servers PyBitmessage will never connect to the network without connecting to bootstrapXXXX.
...

PyBitmessage should not connect to bootstrapXXXX when:

onionservicesonly is enabled, or

trusted mode is used.
Currently there are no guards for these cases.

Thought it cannot be implemented right now because quzwelsuziwqgpt2.onion (sole onion bootstrap server) is down.

Besides the refactoring there is a new complaint from chan: > > If onionservicesonly is enabled and there are no available onion bootstrap servers PyBitmessage will never connect to the network without connecting to bootstrapXXXX. > > When onionservicesonly is enabled, the user expects PyBitmessage not to connect non-onion nodes at all. > So if onion bootstrap nodes are not to be connected, PyBitmessage should stop bootstrapping and show error message. > The user then decides not to use PyBitmessage for a while or to change his policy to connet to non-onion nodes. > Security policy is more important than connectivity. > ... > ------------------------------------------------------ > If onionservicesonly is enabled and there are no available onion bootstrap servers PyBitmessage will never connect to the network without connecting to bootstrapXXXX. > ... > ------------------------------------------------------ > PyBitmessage should not connect to bootstrapXXXX when: > * onionservicesonly is enabled, or > * trusted mode is used. > Currently there are no guards for these cases. Thought it cannot be implemented right now because quzwelsuziwqgpt2.onion (sole onion bootstrap server) is down.

This repo is archived. You cannot comment on issues.