From da7c1514649611074e8bfc4ad2c8ab776d22670b Mon Sep 17 00:00:00 2001 From: Justus Ranvier Date: Tue, 4 Jun 2013 15:13:16 -0500 Subject: [PATCH 1/4] Update Makefile to correct sandbox violations when built via Portage (Gentoo) --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6f415786..6485c2c9 100755 --- a/Makefile +++ b/Makefile @@ -34,7 +34,7 @@ install: install -m 644 src/pyelliptic/*.py $(DEST_APP)/pyelliptic install -m 644 src/socks/*.py $(DEST_APP)/socks install -m 644 src/bitmessageqt/*.py $(DEST_APP)/bitmessageqt - install -m 755 debian/pybm /usr/bin/pybitmessage + install -m 755 debian/pybm $(DESTDIR)/usr/bin/$(APP) install -m 644 desktop/$(APP).desktop $(DEST_SHARE)/applications/$(APP).desktop install -m 644 src/images/can-icon-24px.png $(DEST_SHARE)/icons/hicolor/24x24/apps/$(APP).png -- 2.45.1 From 354c82d85b68ca155a5ae83b3f04b602e77505a4 Mon Sep 17 00:00:00 2001 From: Justus Ranvier Date: Tue, 4 Jun 2013 15:21:53 -0500 Subject: [PATCH 2/4] Ensure $(DESTDIR)/usr/bin exists --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 6485c2c9..d49f63fc 100755 --- a/Makefile +++ b/Makefile @@ -11,6 +11,7 @@ source: tar -cvzf ../$(APP)_$(VERSION).orig.tar.gz ../$(APP)-$(VERSION) --exclude-vcs install: + mkdir -m 755 -p $(DESTDIR)/usr/bin mkdir -m 755 -p $(DEST_APP) mkdir -m 755 -p $(DEST_SHARE)/applications mkdir -m 755 -p $(DEST_APP)/images -- 2.45.1 From 41792697b63dfd1de242ac04d691e1ea01708b12 Mon Sep 17 00:00:00 2001 From: Justus Ranvier Date: Tue, 4 Jun 2013 15:32:14 -0500 Subject: [PATCH 3/4] Add missing trailing semicolons to pybitmessage.desktop --- desktop/pybitmessage.desktop | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/desktop/pybitmessage.desktop b/desktop/pybitmessage.desktop index 363908dd..2b1b6902 100644 --- a/desktop/pybitmessage.desktop +++ b/desktop/pybitmessage.desktop @@ -7,12 +7,12 @@ Comment=Send encrypted messages to another person or to many subscribers Exec=pybitmessage %U Icon=pybitmessage Terminal=false -Categories=Network;Email;Application -Keywords=Email;E-mail;Newsgroup;Messaging +Categories=Network;Email;Application; +Keywords=Email;E-mail;Newsgroup;Messaging; X-MessagingMenu-UsesChatSection=true X-Ubuntu-Gettext-Domain=pybitmessage -Actions=Send;Subscribe;AddressBook +Actions=Send;Subscribe;AddressBook; [Desktop Action Send] Name=Send @@ -27,4 +27,4 @@ OnlyShowIn=Unity; [Desktop Action AddressBook] Name=Address Book Exec=pybitmessage -a -OnlyShowIn=Unity; \ No newline at end of file +OnlyShowIn=Unity; -- 2.45.1 From e7f972ca662123b7f94ac56d01d399679b164227 Mon Sep 17 00:00:00 2001 From: Jonathan Warren Date: Fri, 7 Jun 2013 15:06:53 -0400 Subject: [PATCH 4/4] Correct ECDSA verify --- Makefile | 2 +- debian.sh | 2 +- src/bitmessagemain.py | 16 ++++++++++++---- src/shared.py | 2 +- 4 files changed, 15 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 6f415786..e84d1bc4 100755 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ APP=pybitmessage -VERSION=0.3.2 +VERSION=0.3.3 DEST_SHARE=$(DESTDIR)/usr/share DEST_APP=$(DEST_SHARE)/$(APP) diff --git a/debian.sh b/debian.sh index 69bdcba8..a26398e3 100755 --- a/debian.sh +++ b/debian.sh @@ -8,7 +8,7 @@ APP=pybitmessage PREV_VERSION=0.3.2 -VERSION=0.3.2 +VERSION=0.3.3 ARCH_TYPE=all #update version numbers automatically - so you don't have to diff --git a/src/bitmessagemain.py b/src/bitmessagemain.py index e53fee3a..4f612904 100755 --- a/src/bitmessagemain.py +++ b/src/bitmessagemain.py @@ -650,7 +650,9 @@ class receiveDataThread(threading.Thread): readPosition += signatureLengthLength signature = data[readPosition:readPosition+signatureLength] try: - highlevelcrypto.verify(data[12:readPositionAtBottomOfMessage],signature,sendersPubSigningKey.encode('hex')) + if not highlevelcrypto.verify(data[12:readPositionAtBottomOfMessage],signature,sendersPubSigningKey.encode('hex')): + print 'ECDSA verify failed' + return print 'ECDSA verify passed' except Exception, err: print 'ECDSA verify failed', err @@ -783,7 +785,9 @@ class receiveDataThread(threading.Thread): readPosition += signatureLengthLength signature = decryptedData[readPosition:readPosition+signatureLength] try: - highlevelcrypto.verify(decryptedData[:readPositionAtBottomOfMessage],signature,sendersPubSigningKey.encode('hex')) + if not highlevelcrypto.verify(decryptedData[:readPositionAtBottomOfMessage],signature,sendersPubSigningKey.encode('hex')): + print 'ECDSA verify failed' + return print 'ECDSA verify passed' except Exception, err: print 'ECDSA verify failed', err @@ -1024,7 +1028,9 @@ class receiveDataThread(threading.Thread): readPosition += signatureLengthLength signature = decryptedData[readPosition:readPosition+signatureLength] try: - highlevelcrypto.verify(decryptedData[:positionOfBottomOfAckData],signature,pubSigningKey.encode('hex')) + if not highlevelcrypto.verify(decryptedData[:positionOfBottomOfAckData],signature,pubSigningKey.encode('hex')): + print 'ECDSA verify failed' + return print 'ECDSA verify passed' except Exception, err: print 'ECDSA verify failed', err @@ -1340,7 +1346,9 @@ class receiveDataThread(threading.Thread): signatureLength, signatureLengthLength = decodeVarint(data[readPosition:readPosition+10]) signature = data[readPosition:readPosition+signatureLengthLength] try: - highlevelcrypto.verify(data[8:readPosition],signature,publicSigningKey.encode('hex')) + if not highlevelcrypto.verify(data[8:readPosition],signature,publicSigningKey.encode('hex')): + print 'ECDSA verify failed (within processpubkey)' + return print 'ECDSA verify passed (within processpubkey)' except Exception, err: print 'ECDSA verify failed (within processpubkey)', err diff --git a/src/shared.py b/src/shared.py index 1aaa0d3a..acc8b3a2 100644 --- a/src/shared.py +++ b/src/shared.py @@ -1,4 +1,4 @@ -softwareVersion = '0.3.211' +softwareVersion = '0.3.3' import threading import sys -- 2.45.1