Bitmessage/PyBitmessage-2024-12-21
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 52 Actions Packages Projects Releases 5 Wiki Activity

Blacklist API #740

Merged
hackergrrl merged 2 commits from blacklist_api into master 2014-12-26 04:12:42 +01:00
Conversation 1 Commits 2 Files Changed 2 +86 -28
hackergrrl commented 2014-11-22 23:07:18 +01:00 (Migrated from github.com)
Copy Link

Addresses #496.

This PR adds two new API commands: addAddressToBlackWhiteList and removeAddressFromBlackWhiteList, which add and remove black-/white-list entries (respectively) depending on which of (blacklist|whitelist) the user has set.

Two new API codes (28 and 29) are added for alerting API clients of when an entry already exists or does not exist (also respectively).

In bitmessageqt/__init__.py loadBlackWhiteList is refactored into rerenderBlackWhiteList to be more consistent with the rest of the rerender methods. Finally, it also accepts a new UI signal to refresh the black-/white-list UI pane.

There was no testing suite to speak of, but I did test the breadth of the functionality manually as thoroughly as I could.

Addresses #496. This PR adds two new API commands: `addAddressToBlackWhiteList` and `removeAddressFromBlackWhiteList`, which add and remove black-/white-list entries (respectively) depending on which of `(blacklist|whitelist)` the user has set. Two new API codes (28 and 29) are added for alerting API clients of when an entry already exists or does not exist (also respectively). In `bitmessageqt/__init__.py` `loadBlackWhiteList` is refactored into `rerenderBlackWhiteList` to be more consistent with the rest of the rerender methods. Finally, it also accepts a new UI signal to refresh the black-/white-list UI pane. There was no testing suite to speak of, but I did test the breadth of the functionality manually as thoroughly as I could.
Atheros1 commented 2014-12-26 04:12:23 +01:00 (Migrated from github.com)
Copy Link

This works excellently for me. Thank you!

This works excellently for me. Thank you!
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-21#740
No description provided.
Delete Branch "blacklist_api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?