New POW calculation module #1284

Open
Kleshni wants to merge 38 commits from Kleshni/POW into v0.6
7 changed files with 80 additions and 63 deletions
Showing only changes of commit c28a4f6174 - Show all commits

View File

@ -12,7 +12,7 @@ from src.version import softwareVersion
EXTRAS_REQUIRE = {
'gir': ['pygobject'],
'notify2': ['notify2'],
'pyopencl': ['numpy', 'pyopencl'],
'pyopencl': ['pyopencl', 'numpy'],
'prctl': ['python_prctl'], # Named threads
'qrcode': ['qrcode'],
'sound;platform_system=="Windows"': ['winsound'],

View File

@ -28,7 +28,7 @@ class Task(object):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.target = target
class WorkProver(threading.Thread):
def __init__(self, codePath, GPUVendors, seed, statusUpdated):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
def __init__(self, codePath, GPUVendor, seed, statusUpdated):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
super(self.__class__, self).__init__()
self.availableSolvers = {
@ -51,7 +51,7 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
pass
try:
self.availableSolvers["gpu"] = gpusolver.GPUSolver(codePath, GPUVendors)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.availableSolvers["gpu"] = gpusolver.GPUSolver(codePath, GPUVendor)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
except gpusolver.GPUSolverError:
pass
@ -81,32 +81,31 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
if self.statusUpdated is None:
return
if self.solver is None:
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
parallelism = 0
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
else:
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
parallelism = self.solver.parallelism
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
status = None
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.statusUpdated((self.solverName, parallelism, self.speed))
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
if self.solver is not None:
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
status = self.solver.status
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
def setSolver(self, name, parallelism):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.statusUpdated((self.solverName, status, self.speed))
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
def setSolver(self, name, configuration):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
if name is None and self.solverName is None:
pass
omkar1117 commented 2018-06-23 11:26:47 +02:00 (Migrated from github.com)
Review

if not self.statusUpdated:
return

if not self.statusUpdated: return
Kleshni commented 2018-06-23 12:39:06 +02:00 (Migrated from github.com)
Review

It's less acurate.

self.statusUpdated must be either a function or a None. If it's 0 or an empty string, it would be a programming error and further call would rise an exception making the error noticable.

It's less acurate. `self.statusUpdated` must be either a function or a `None`. If it's 0 or an empty string, it would be a programming error and further call would rise an exception making the error noticable.
elif name == self.solverName:
if self.solver.parallelism != parallelism:
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.solver.setParallelism(parallelism)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.solver.setConfiguration(configuration)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
else:
if self.solver is not None:
self.solver.setParallelism(0)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.solver.setConfiguration(None)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.solverName = None
self.solver = None
if name is not None:
if name not in self.availableSolvers:
name, parallelism = "dumb", 1
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
name, configuration = "dumb", None
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.solverName = name
self.solver = self.availableSolvers[name]
self.solver.setParallelism(parallelism)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.solver.setConfiguration(configuration)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.notifyStatus()
@ -175,7 +174,7 @@ class WorkProver(threading.Thread):
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.currentTaskID = self.tasks[self.currentTaskID].next
def shutdown(self):
self.setSolver(None, 0)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
self.setSolver(None, None)
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
for i in self.tasks.keys():
self.cancelTask(i)

omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:19:26 +02:00 (Migrated from github.com)
Review

pass is the dangerous statement, please log it or please write a print statement atleast...

pass is the dangerous statement, please log it or please write a print statement atleast...
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:23:40 +02:00 (Migrated from github.com)
Review

parallelism = self.solver.parallelism if self.solver else 0

parallelism = self.solver.parallelism if self.solver else 0
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:27:44 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName

if not name and not self.solverName
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:02 +02:00 (Migrated from github.com)
Review

logging is required for this functionality.

logging is required for this functionality.
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:26 +02:00 (Migrated from github.com)
Review

if not self.solver

if not self.solver
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:28:41 +02:00 (Migrated from github.com)
Review

if not name

if not name
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:45:55 +02:00 (Migrated from github.com)
Review

doc string required here

doc string required here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:46:34 +02:00 (Migrated from github.com)
Review

docstring here

docstring here
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:47:06 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:50:56 +02:00 (Migrated from github.com)
Review

docstring here please

docstring here please
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:15 +02:00 (Migrated from github.com)
Review

if not self.tasks

if not self.tasks
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:53:58 +02:00 (Migrated from github.com)
Review

pep8 validation

pep8 validation
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
omkar1117 commented 2018-06-23 11:56:19 +02:00 (Migrated from github.com)
Review

@PeterSurda , I think we need optimization here.

@PeterSurda , I think we need optimization here.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:32:58 +02:00 (Migrated from github.com)
Review

self.availableSolvers is visible to the outside code, so it can log or print if fast is missing. It should show a message in GUI status bar like the current code does.

`self.availableSolvers` is visible to the outside code, so it can log or print if `fast` is missing. It should show a message in GUI status bar like the current code does.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:34:24 +02:00 (Migrated from github.com)
Review

It's less readable.

It's less readable.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
Kleshni commented 2018-06-23 12:44:26 +02:00 (Migrated from github.com)
Review

It calls the self.statusUpdated callback and the outside code should log this and display in the GUI.

It calls the `self.statusUpdated` callback and the outside code should log this and display in the GUI.
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:09 +02:00 (Migrated from github.com)
Review

if not name and not self.solverName:
pass

if not name and not self.solverName: pass
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:25 +02:00 (Migrated from github.com)
Review

if self.solver:
….

if self.solver: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
omkar1117 commented 2018-07-25 06:08:36 +02:00 (Migrated from github.com)
Review

if name:
….

if name: ….
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'
g1itch commented 2018-08-02 15:52:45 +02:00 (Migrated from github.com)
Review

undefined name 'GPUSolverError'

undefined name 'GPUSolverError'

View File

@ -24,7 +24,7 @@ class DumbSolver(object):
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
self.firstHash = ctypes.create_string_buffer(64)
self.secondHash = ctypes.create_string_buffer(64)
self.parallelism = 1
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
self.status = None
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
def search(self, initialHash, target, seed, timeout):
startTime = utils.getTimePoint()
@ -66,5 +66,5 @@ class DumbSolver(object):
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
if utils.getTimePoint() - startTime >= timeout:
return None, 256 * i
def setParallelism(self, parallelism):
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
def setConfiguration(self, configuration):
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
pass

omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.
omkar1117 commented 2018-06-23 11:57:55 +02:00 (Migrated from github.com)
Review

docs here and pep8 validation.

docs here and pep8 validation.

View File

@ -58,6 +58,7 @@ class FastSolver(object):
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
self.iterationsCount = ctypes.c_ulonglong()
self.parallelism = 0
self.status = 0
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
def search(self, initialHash, target, seed, timeout):
found = self.libfastsolver.fastsolver_search(
@ -70,11 +71,16 @@ class FastSolver(object):
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
else:
return None, self.iterationsCount.value
def setParallelism(self, parallelism):
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
parallelism = min(4096, parallelism)
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
def setConfiguration(self, configuration):
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
if configuration is None:
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
parallelism = 0
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
else:
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
parallelism = min(4096, configuration)
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
for i in xrange(self.parallelism, parallelism):
self.parallelism = self.libfastsolver.fastsolver_add()
if parallelism < self.parallelism:
self.parallelism = self.libfastsolver.fastsolver_remove(self.parallelism - parallelism)
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
self.status = parallelism
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here

omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:58:58 +02:00 (Migrated from github.com)
Review

doc type required here

doc type required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here
omkar1117 commented 2018-06-23 11:59:54 +02:00 (Migrated from github.com)
Review

documentation required here

documentation required here

View File

@ -5,6 +5,11 @@ import struct
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
import dumbsolver
def setIdle():
if hasattr(os, "nice"):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
os.nice(40)
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
return
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
try:
import psutil
@ -23,14 +28,9 @@ def setIdle():
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
handle = win32api.OpenProcess(win32con.PROCESS_ALL_ACCESS, True, PID)
win32process.SetPriorityClass(handle, win32process.IDLE_PRIORITY_CLASS)
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
return
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
except:
pass
if hasattr(os, "nice"):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
os.nice(40)
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
def threadFunction(local, remote, codePath, threadNumber):
remote.close()
setIdle()
@ -60,7 +60,7 @@ class ForkingSolver(object):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
self.pipes = []
self.processes = []
self.parallelism = 0
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
self.status = 0
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
self.codePath = codePath
@ -80,10 +80,13 @@ class ForkingSolver(object):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
return bestNonce, totalIterationsCount
def setParallelism(self, parallelism):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
parallelism = min(4096, parallelism)
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
def setConfiguration(self, configuration):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
if configuration is None:
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
parallelism = 0
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
else:
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
parallelism = min(4096, configuration)
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
for i in xrange(self.parallelism, parallelism):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
for i in xrange(len(self.processes), parallelism):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
local, remote = multiprocessing.Pipe()
process = multiprocessing.Process(target = threadFunction, args = (remote, local, self.codePath, i))
@ -94,13 +97,13 @@ class ForkingSolver(object):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
self.pipes.append(local)
self.processes.append(process)
for i in xrange(parallelism, self.parallelism):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
for i in xrange(parallelism, len(self.processes)):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
pipe = self.pipes.pop()
pipe.send(("shutdown", ))
pipe.close()
for i in xrange(parallelism, self.parallelism):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
for i in xrange(parallelism, len(self.processes)):
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
self.processes.pop().join()
self.parallelism = parallelism
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
self.status = parallelism
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces

omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces
omkar1117 commented 2018-06-23 12:07:47 +02:00 (Migrated from github.com)
Review

remove un necessary spaces

remove un necessary spaces

View File

@ -11,53 +11,31 @@ class GPUSolverError(Exception):
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
pass
class GPUSolver(object):
def __init__(self, codePath, vendors = None):
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
global pyopencl, numpy
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
def __init__(self, codePath, vendor = None):
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
global pyopencl
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
try:
import numpy
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
import pyopencl
except ImportError:
raise GPUSolverError()
device = None
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
for i in pyopencl.get_platforms():
if vendors is not None and i.vendor not in vendors:
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
if vendor is not None and i.vendor != vendor:
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
continue
devices = i.get_devices(device_type = pyopencl.device_type.GPU)
if len(devices) != 0:
device = devices[0]
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.device = devices[0]
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
break
else:
raise GPUSolverError()
context = pyopencl.Context(devices = [device])
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
computeUnitsCount = device.get_info(pyopencl.device_info.MAX_COMPUTE_UNITS)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
workGroupSize = device.get_info(pyopencl.device_info.MAX_WORK_GROUP_SIZE)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.parallelism = workGroupSize * computeUnitsCount
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.batchSize = self.parallelism * 256
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.queue = pyopencl.CommandQueue(context, device)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
with open(os.path.join(codePath, "gpusolver.cl")) as file:
source = file.read()
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.source = file.read()
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
program = pyopencl.Program(context, source).build()
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.hostOutput = numpy.zeros(1 + self.batchSize, numpy.uint32)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.hostInput = numpy.zeros(1 + 8 + 1, numpy.uint64)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.output = pyopencl.Buffer(context, pyopencl.mem_flags.READ_WRITE, 4 * (1 + self.batchSize))
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.input = pyopencl.Buffer(context, pyopencl.mem_flags.READ_ONLY, 8 * (1 + 8 + 1))
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.kernel = program.search
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.kernel.set_args(self.output, self.input)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.status = None
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
def search(self, initialHash, target, seed, timeout):
startTime = utils.getTimePoint()
@ -102,5 +80,32 @@ class GPUSolver(object):
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
if utils.getTimePoint() - startTime >= timeout:
return None, self.batchSize * i
def setParallelism(self, parallelism):
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
pass
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
def setConfiguration(self, configuration):
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
global numpy
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
if numpy is not None:
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
return
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
import numpy
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
context = pyopencl.Context(devices = [self.device])
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
computeUnitsCount = self.device.get_info(pyopencl.device_info.MAX_COMPUTE_UNITS)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
workGroupSize = self.device.get_info(pyopencl.device_info.MAX_WORK_GROUP_SIZE)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.batchSize = workGroupSize * computeUnitsCount * 256
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.queue = pyopencl.CommandQueue(context, self.device)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
program = pyopencl.Program(context, self.source).build()
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.hostOutput = numpy.zeros(1 + self.batchSize, numpy.uint32)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.hostInput = numpy.zeros(1 + 8 + 1, numpy.uint64)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.output = pyopencl.Buffer(context, pyopencl.mem_flags.READ_WRITE, 4 * (1 + self.batchSize))
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.input = pyopencl.Buffer(context, pyopencl.mem_flags.READ_ONLY, 8 * (1 + 8 + 1))
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.kernel = program.search
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.kernel.set_args(self.output, self.input)
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
self.status = self.batchSize
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?

g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?
g1itch commented 2018-06-27 11:47:35 +02:00 (Migrated from github.com)
Review

Could you please comment #1283 and maybe change the import order too if you agree?

Could you please comment #1283 and maybe change the import order too if you agree?

View File

@ -85,7 +85,7 @@ class TestSolver(unittest.TestCase):
except gpusolver.GPUSolverError:
self.skipTest("OpenCL unavailable")
self.solver.setParallelism(1)
self.solver.setConfiguration(self.configuration)
def testSearch(self):
nonce = None
@ -101,19 +101,23 @@ class TestSolver(unittest.TestCase):
self.assertTrue(utils.checkProof(nonce, initialHash, target))
def tearDown(self):
self.solver.setParallelism(0)
self.solver.setConfiguration(None)
class TestDumbSolver(TestSolver):
Solver = dumbsolver.DumbSolver
configuration = None
class TestForkingSolver(TestSolver):
Solver = forkingsolver.ForkingSolver
configuration = 1
class TestFastSolver(TestSolver):
Solver = fastsolver.FastSolver
configuration = 1
class TestGPUSolver(TestSolver):
Solver = gpusolver.GPUSolver
configuration = None
class TestWorkProver(unittest.TestCase):
def setUp(self):