Bitmessage/PyBitmessage-2024-12-22
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 52 Actions Packages Projects Releases 5 Wiki Activity

Not all new messages are shown on the subscriptions tab #856

New Issue
Open
opened 2016-05-06 16:02:37 +02:00 by yurivict · 14 comments
yurivict commented 2016-05-06 16:02:37 +02:00 (Migrated from github.com)
Copy Link

'Subscriptions' tab shows that there are new messages (in bold), but not all new messages are displayed there. 'Messages' tab though shows all new messages from the subscription channels.

'Subscriptions' tab shows that there are new messages (in bold), but not all new messages are displayed there. 'Messages' tab though shows all new messages from the subscription channels.
PeterSurda commented 2016-05-08 17:52:37 +02:00 (Migrated from github.com)
Copy Link

I'm not sure I understand. Can you send me a screenshot maybe? That being said, there are two bugs that could be related:

  • when you start, no subscription/chan is selected and all of them are shown
  • when you read a message in "all" or under subscription/chan, the list is not updated in the other one

But that does not sound like what you're describing.

I'm not sure I understand. Can you send me a screenshot maybe? That being said, there are two bugs that could be related: - when you start, no subscription/chan is selected and all of them are shown - when you read a message in "all" or under subscription/chan, the list is not updated in the other one But that does not sound like what you're describing.
yurivict commented 2016-05-09 04:59:29 +02:00 (Migrated from github.com)
Copy Link
  1. Subscription's "inbox" shows 1 new message (in bold).
  2. When I click on the inbox this new message isn't displayed in the list of messages to the right.
  3. To see the message I have to switch to the "Messages" tab where it is shown under "All accounts".
1. Subscription's "inbox" shows 1 new message (in bold). 2. When I click on the inbox this new message isn't displayed in the list of messages to the right. 3. To see the message I have to switch to the "Messages" tab where it is shown under "All accounts".
PeterSurda commented 2016-05-09 19:24:17 +02:00 (Migrated from github.com)
Copy Link

Could it be that you have something in the search field?

Could it be that you have something in the search field?
yurivict commented 2016-05-09 20:21:30 +02:00 (Migrated from github.com)
Copy Link

No, search field is empty.

No, search field is empty.
PeterSurda commented 2016-05-10 16:52:28 +02:00 (Migrated from github.com)
Copy Link

It's likely that this was a bug in the indicator of the number of new messages (there have been many over the time and maybe there still is one) rather than a bug in the list of messages in the inbox. If that's the case, the message would have been displayed, but it wouldn't have been bold. Is it possible?

It's likely that this was a bug in the indicator of the number of new messages (there have been many over the time and maybe there still is one) rather than a bug in the list of messages in the inbox. If that's the case, the message would have been displayed, but it wouldn't have been bold. Is it possible?
yurivict commented 2016-05-10 18:51:29 +02:00 (Migrated from github.com)
Copy Link

No, there are new messages that are received for the subscription, indicator shows it right. But they aren't in the list of this particular subscription. Some messages don't show under their subscriptions.

No, there are new messages that are received for the subscription, indicator shows it right. But they aren't in the list of this particular subscription. Some messages don't show under their subscriptions.
PeterSurda commented 2016-05-10 19:01:30 +02:00 (Migrated from github.com)
Copy Link

Ok I will check.

Ok I will check.
yurivict commented 2016-05-11 17:34:46 +02:00 (Migrated from github.com)
Copy Link

I have an additional info. This particular subscription is added in both Chans and Subscriptions tabs. (Not sure if this is supposed to be allowed)

"All accounts" list seems correct. "Subscriptions" tab correctly shows the count of new messages in bold (Inbox (N)) but the list is missing many of them. "Chans" shows the correct count and list but all of them are marked as "unread", regardless if they have been read on another tabs.

So, there are two problems:

  1. "Subscriptions" tab is missing messages in the list
  2. "Chans" tab has "unread" flag set wrongfully on the already read messages.

Additionally, it isn't clear to me if the same item should be allowed to be added to both Subscriptions and Chans. Not sure even what is the difference.

I have an additional info. This particular subscription is added in both Chans and Subscriptions tabs. (Not sure if this is supposed to be allowed) "All accounts" list seems correct. "Subscriptions" tab correctly shows the count of new messages in bold (Inbox (N)) but the list is missing many of them. "Chans" shows the correct count and list but all of them are marked as "unread", regardless if they have been read on another tabs. So, there are two problems: 1. "Subscriptions" tab is missing messages in the list 2. "Chans" tab has "unread" flag set wrongfully on the already read messages. Additionally, it isn't clear to me if the same item should be allowed to be added to both Subscriptions and Chans. Not sure even what is the difference.
PeterSurda commented 2016-05-11 23:11:07 +02:00 (Migrated from github.com)
Copy Link

I see. That would explain the misbehaviour. While technically it is possible to use the same key for both a subscription and a chan, it makes little practical sense and will very likely screw up the UI. The reason it makes little practical sense is that it results in a combination of disadvantages of both mechanisms: since all the chan subscribers know the private key, they all can send broadcasts with that key, which makes the broadcast author unauthenticated, which makes no sense. I could change the UI so that it's displayed correctly but it's too much work for a useless situation. I'm too lazy to check, but most likely the lists of messages are correct, just the indicator of unread message count is wrong.

If you are expecting to see chan messages under subscriptions, it means is a broader UI issue, i.e. it didn't explain to you the difference between chans and subscriptions. I also didn't understand it when I started working on it and I actually broke it in early releases of the new UI. There is a ticket open about explaining how it works to the user.

I see. That would explain the misbehaviour. While technically it is possible to use the same key for both a subscription and a chan, it makes little practical sense and will very likely screw up the UI. The reason it makes little practical sense is that it results in a combination of disadvantages of both mechanisms: since all the chan subscribers know the private key, they all can send broadcasts with that key, which makes the broadcast author unauthenticated, which makes no sense. I could change the UI so that it's displayed correctly but it's too much work for a useless situation. I'm too lazy to check, but most likely the lists of messages are correct, just the indicator of unread message count is wrong. If you are expecting to see chan messages under subscriptions, it means is a broader UI issue, i.e. it didn't explain to you the difference between chans and subscriptions. I also didn't understand it when I started working on it and I actually broke it in early releases of the new UI. There is a ticket open about explaining how it works to the user.
yurivict commented 2016-05-11 23:38:12 +02:00 (Migrated from github.com)
Copy Link

If this is impractical you should make UI not allow to add the same item under both Subscriptions and Chans with an explanation why and possible choices.

If this is impractical you should make UI not allow to add the same item under both Subscriptions and Chans with an explanation why and possible choices.
PeterSurda commented 2016-05-11 23:39:51 +02:00 (Migrated from github.com)
Copy Link

I believe it won't allow you to add a duplicate already, you probably imported the setup from an earlier version.

I believe it won't allow you to add a duplicate already, you probably imported the setup from an earlier version.
ghost commented 2016-05-12 02:11:05 +02:00 (Migrated from github.com)
Copy Link

What about renaming the subscriptions tab to "Broadcasts"? That would make it more clear.

What about renaming the subscriptions tab to "Broadcasts"? That would make it more clear.
yurivict commented 2016-05-12 02:46:52 +02:00 (Migrated from github.com)
Copy Link

Possibly. But it is difficult to understand what the difference between them is. I think there should be notes on the tabs explaining the difference. Because chans are also broadcasts.

Possibly. But it is difficult to understand what the difference between them is. I think there should be notes on the tabs explaining the difference. Because chans are also broadcasts.
PeterSurda commented 2016-06-05 17:49:08 +02:00 (Migrated from github.com)
Copy Link

I actually did some changes about this in 6dff105a5b, can you check out the current v0.6 branch if it helps?

I actually did some changes about this in https://github.com/Bitmessage/PyBitmessage/commit/6dff105a5b771c443d5ffbd5372a076fdb759712, can you check out the current v0.6 branch if it helps?
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.8.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-22#856
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?