Bitmessage/PyBitmessage-2024-12-25
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 52 Actions Packages Projects Releases 5 Wiki Activity

Added AppImage build script for PyBitmessage #1769

Closed
kdcis wants to merge 3 commits from v0.6-appimage into v0.6
pull from: v0.6-appimage
merge into: Bitmessage:v0.6
Conversation 5 Commits 3 Files Changed 4 +81
kdcis commented 2021-05-27 16:43:25 +02:00 (Migrated from github.com)
Copy Link

Added AppImage build scripts under packages/AppImage/

Added build instructions under docs/

### Added AppImage build scripts under ```packages/AppImage/``` ### Added build instructions under ```docs/```
g1itch commented 2021-05-28 15:19:42 +02:00 (Migrated from github.com)
Copy Link

Could you build the appimage on travis?

Could you build the appimage on travis?
g1itch commented 2021-05-28 15:22:20 +02:00 (Migrated from github.com)
Copy Link

Please don't include binary. It's build should be part of release process.

Please don't include binary. It's build should be part of release process.
👍 1
g1itch (Migrated from github.com) reviewed 2021-05-31 18:33:34 +02:00
packages/AppImage/install.sh
g1itch (Migrated from github.com) commented 2021-05-31 18:33:34 +02:00

this requires root

this requires root
kdcis (Migrated from github.com) reviewed 2021-05-31 18:50:28 +02:00
packages/AppImage/install.sh
kdcis (Migrated from github.com) commented 2021-05-31 18:50:27 +02:00

Yes, is that a problem?. If yes, I can change so it won't require root.

Yes, is that a problem?. If yes, I can change so it won't require root.
g1itch (Migrated from github.com) reviewed 2021-05-31 18:59:00 +02:00
packages/AppImage/install.sh
g1itch (Migrated from github.com) commented 2021-05-31 18:59:00 +02:00

I'm not sure. Let's check: https://github.com/g1itch/PyBitmessage/commits/ci-wine-further

I'm not sure. Let's check: https://github.com/g1itch/PyBitmessage/commits/ci-wine-further
g1itch commented 2021-05-31 20:11:27 +02:00 (Migrated from github.com)
Copy Link

I see some issue with script: https://travis-ci.org/github/g1itch/PyBitmessage/jobs/773056006, need to check it manually as well.

Also mark the last commit as closing #1450 when finish.

I see some issue with script: https://travis-ci.org/github/g1itch/PyBitmessage/jobs/773056006, need to check it manually as well. Also mark the last commit as closing #1450 when finish.
👍 1
g1itch commented 2021-05-31 21:08:32 +02:00 (Migrated from github.com)
Copy Link

OK, I found possible fix for AppRun: efefa4f. Bad news: this appimage still requires PyQt4 installed system wide.

OK, I found possible fix for AppRun: efefa4f. Bad news: this appimage still requires PyQt4 installed system wide.
g1itch (Migrated from github.com) reviewed 2021-05-31 21:35:01 +02:00
packages/AppImage/install.sh
g1itch (Migrated from github.com) commented 2021-05-31 21:35:00 +02:00

It should work without root: a67ad09

It should work without root: a67ad09
kdcis (Migrated from github.com) reviewed 2021-06-01 08:36:25 +02:00
packages/AppImage/install.sh
kdcis (Migrated from github.com) commented 2021-06-01 08:36:25 +02:00

OKay, I'll make the changes.

OKay, I'll make the changes.
g1itch commented 2021-06-01 15:58:41 +02:00 (Migrated from github.com)
Copy Link

Please squash two first commits to not bloat the repo. Also we need dependencies inside of the bundle, because its purpose is to work around the removal of PyQt4 and python2.

Please squash two first commits to not bloat the repo. Also we need dependencies inside of the bundle, because its purpose is to work around the removal of PyQt4 and python2.
👍 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-25#1769
No description provided.
Delete Branch "v0.6-appimage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?