Bitmessage/PyBitmessage-2025-02-18
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Bug fix: Conversion from QString to standard string #223

Closed
ghost wants to merge 1 commits from master into master
pull from: master
merge into: Bitmessage:master
Conversation 5 Commits 1 Files Changed 1 +3 -3
ghost commented 2013-06-19 12:30:36 +02:00 (Migrated from github.com)
Copy Link
No description provided.
Atheros1 commented 2013-06-20 13:18:51 +02:00 (Migrated from github.com)
Copy Link

I believe that str() will fail if given international characters. The following works for the normal tray notification. Does it work for the Notify.Notification menu?

self.notifierShow('Bitmessage', unicode(_translate("MainWindow", "Connected").toUtf8(),'utf-8'))
I believe that str() will fail if given international characters. The following works for the normal tray notification. Does it work for the Notify.Notification menu? ``` self.notifierShow('Bitmessage', unicode(_translate("MainWindow", "Connected").toUtf8(),'utf-8')) ```
ghost commented 2013-06-20 13:24:40 +02:00 (Migrated from github.com)
Copy Link

Traceback (most recent call last):
File "/usr/share/pybitmessage/bitmessageqt/init.py", line 895, in updateNetworkStatusTab
self.setStatusIcon('yellow')
File "/usr/share/pybitmessage/bitmessageqt/init.py", line 925, in setStatusIcon
unicode(_translate("MainWindow","Connected").toUtf8(),'utf-8'))
NameError: global name '_translate' is not defined

Traceback (most recent call last): File "/usr/share/pybitmessage/bitmessageqt/**init**.py", line 895, in updateNetworkStatusTab self.setStatusIcon('yellow') File "/usr/share/pybitmessage/bitmessageqt/**init**.py", line 925, in setStatusIcon unicode(_translate("MainWindow","Connected").toUtf8(),'utf-8')) NameError: global name '_translate' is not defined
Atheros1 commented 2013-06-20 13:30:26 +02:00 (Migrated from github.com)
Copy Link

Oh, pardon me. I'm working off of the latest code.
This doesn't use _translate :
self.notifierShow('Bitmessage', unicode(QtGui.QApplication.translate"MainWindow", "Connected").toUtf8(),'utf-8'))

Oh, pardon me. I'm working off of the latest code. This doesn't use _translate : self.notifierShow('Bitmessage', unicode(QtGui.QApplication.translate"MainWindow", "Connected").toUtf8(),'utf-8'))
ghost commented 2013-06-20 13:39:31 +02:00 (Migrated from github.com)
Copy Link

Yes that works.

Yes that works.
Atheros1 commented 2013-06-20 22:44:39 +02:00 (Migrated from github.com)
Copy Link

Merged. Tested normal notifications: successful. You may still want to test the messaging menu. I added the "translate" functions to the 'New Message' notification; it was missed previously.
Thank you

Merged. Tested normal notifications: successful. You may still want to test the messaging menu. I added the "translate" functions to the 'New Message' notification; it was missed previously. Thank you
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-18#223
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?