Bitmessage/PyBitmessage-2025-02-19
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Added trashSentMessageByAckData API command #453

Merged
acejam merged 1 commits from master into master 2013-08-29 04:10:14 +02:00
Conversation 2 Commits 1 Files Changed 1 +13
acejam commented 2013-08-27 04:45:00 +02:00 (Migrated from github.com)
Copy Link

For a while the msgid was not stored in the sent table. Current API commands only allow deletion of messages using msgid. I have added the trashSentMessageByAckData.API command which will allow deletion of sent messages using ackdata.

My intention of this commit is to help maintain backwards compatibility, allowing older sent messages to be deleted. However, I believe the preferred method of deleting messages should be done using msgid. Therefore, perhaps this API command should only be used as a "last resort".

Another benefit of using trashSentMessageByAckData is that an outgoing message can be "canceled". In other words, the message can be deleted while it is still in the PoW phase.

For a while the msgid was not stored in the sent table. Current API commands only allow deletion of messages using msgid. I have added the trashSentMessageByAckData.API command which will allow deletion of sent messages using ackdata. My intention of this commit is to help maintain backwards compatibility, allowing older sent messages to be deleted. However, I believe the preferred method of deleting messages should be done using msgid. Therefore, perhaps this API command should only be used as a "last resort". Another benefit of using trashSentMessageByAckData is that an outgoing message can be "canceled". In other words, the message can be deleted while it is still in the PoW phase.
robzon commented 2013-08-27 10:38:18 +02:00 (Migrated from github.com)
Copy Link

+1

+1
Atheros1 commented 2013-08-29 04:10:33 +02:00 (Migrated from github.com)
Copy Link

Sounds useful to me. Thank you.

Sounds useful to me. Thank you.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-19#453
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?