Bitmessage/PyBitmessage-2025-02-21
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Changes based on style and lint checks. (final_code_quality_6) #1364

Merged
coffeedogs merged 1 commits from final_code_quality_6 into v0.6 2018-10-20 15:19:25 +02:00
Conversation 6 Commits 1 Files Changed 2 +240 -128
coffeedogs commented 2018-10-10 12:46:12 +02:00 (Migrated from github.com)
Copy Link

Changes based on style and lint checks. (final_code_quality_6)

Changes based on style and lint checks. (final_code_quality_6)
PeterSurda (Migrated from github.com) reviewed 2018-10-12 09:41:47 +02:00
src/api.py
PeterSurda (Migrated from github.com) commented 2018-10-12 09:41:47 +02:00

@coffeedogs This print should be removed, as well as other prints in this file, however this is a separate task so I created a new issue and assigned it to you.

@coffeedogs This print should be removed, as well as other prints in this file, however this is a separate task so I created a new issue and assigned it to you.
PeterSurda (Migrated from github.com) approved these changes 2018-10-12 09:43:19 +02:00
PeterSurda (Migrated from github.com) approved these changes 2018-10-14 18:04:39 +02:00
PeterSurda commented 2018-10-14 18:10:22 +02:00 (Migrated from github.com)
Copy Link

I think the commit isn't signed, other than that it's ready to go.

I think the commit isn't signed, other than that it's ready to go.
coffeedogs commented 2018-10-18 20:51:37 +02:00 (Migrated from github.com)
Copy Link

Guessing that wasn't signed since I only had a project-level enforce set in git config and was using a separate directory to do this rebasing. I've now set git's enforced signing to be global, thanks for the vigilance!

Guessing that wasn't signed since I only had a project-level enforce set in git config and was using a separate directory to do this rebasing. I've now set git's enforced signing to be global, thanks for the vigilance!
PeterSurda commented 2018-10-20 16:27:09 +02:00 (Migrated from github.com)
Copy Link

Oh you can merge it yourself as long as all the required conditions pass, that's cool, I didn't know that.

Oh you can merge it yourself as long as all the required conditions pass, that's cool, I didn't know that.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
PeterSurda
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
developers
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-21#1364
No description provided.
Delete Branch "final_code_quality_6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?