Bitmessage/PyBitmessage-2025-02-22
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Optionally reply below quote (email style) #633

Merged
domob1812 merged 3 commits from email-quoting into master 2014-04-30 22:49:06 +02:00
Conversation 2 Commits 3 Files Changed 4 +110 -79
domob1812 commented 2014-01-28 21:01:12 +01:00 (Migrated from github.com)
Copy Link

This is an extended version of the patch submitted already in https://github.com/Bitmessage/PyBitmessage/pull/271, see also https://bitmessage.org/forum/index.php?topic=3644.0. This version implements a new preference (which is off by default) and only uses the new quoting style if the user actively sets the preference to on (opt-in).

This is an extended version of the patch submitted already in https://github.com/Bitmessage/PyBitmessage/pull/271, see also https://bitmessage.org/forum/index.php?topic=3644.0. This version implements a new preference (which is off by default) and only uses the new quoting style if the user actively sets the preference to on (opt-in).
Dinduks commented 2014-04-08 23:48:48 +02:00 (Migrated from github.com)
Copy Link

I didn't see this PR when I did #657.
Why does it take so many LoC to add > to the start of each line?

I think it'd be great to have a separator (like XXX wrote:) before of each quote.
I also, you had to rebase master in email-quoting instead of merging, thus not creating a new commit.

👍 for the checkbox in the preferences.

I didn't see this PR when I did #657. Why does it take so many LoC to add `>` to the start of each line? I think it'd be great to have a separator (like _XXX wrote:_) before of each quote. I also, you had to rebase _master_ in _email-quoting_ instead of merging, thus not creating a new commit. :+1: for the checkbox in the preferences.
Atheros1 commented 2014-04-30 22:50:16 +02:00 (Migrated from github.com)
Copy Link

Thank you domob. I apologize for the long wait to review and merge.

Thank you domob. I apologize for the long wait to review and merge.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-22#633
No description provided.
Delete Branch "email-quoting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?