Bitmessage/PyBitmessage-2025-02-23
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Fix issue #183 (CPU 100% usage) #277

Merged
ghost merged 1 commits from cpu100percentfix into master 2013-07-01 19:05:39 +02:00
Conversation 8 Commits 1 Files Changed 1 +3
ghost commented 2013-07-01 07:55:28 +02:00 (Migrated from github.com)
Copy Link

As per http://docs.python.org/2/howto/sockets.html#using-a-socket it's
possible that a socket recv() call returns 0 bytes if the remote closes
the connection. In that case, recv() does not obey settimeout(): it
just doesn't block and returns zero bytes immediately, which in this
case results in an infinite loop if the transmission was incomplete.

As per http://docs.python.org/2/howto/sockets.html#using-a-socket it's possible that a socket recv() call returns 0 bytes if the remote closes the connection. In that case, recv() does not obey settimeout(): it just doesn't block and returns zero bytes immediately, which in this case results in an infinite loop if the transmission was incomplete.
linkerlin commented 2013-07-01 09:29:32 +02:00 (Migrated from github.com)
Copy Link

Good job!

Good job!
RexMorgan commented 2013-07-01 09:52:34 +02:00 (Migrated from github.com)
Copy Link

👍 bravo

:+1: bravo
DivineOmega commented 2013-07-01 10:27:25 +02:00 (Migrated from github.com)
Copy Link

Again, well done on pin pointing the exact issue! Hopefully this is the only potential infinite loop in existence.

Again, well done on pin pointing the exact issue! Hopefully this is the only potential infinite loop in existence.
ghost commented 2013-07-01 15:40:15 +02:00 (Migrated from github.com)
Copy Link

This does seem to be working. If BM is still well behaved by the end of the day then I think we can call this issue fixed.

This does seem to be working. If BM is still well behaved by the end of the day then I think we can call this issue fixed.
RexMorgan commented 2013-07-01 17:36:48 +02:00 (Migrated from github.com)
Copy Link

I've been running BM with this patch for about 9 hours, now. It looks like the issue is resolved. Although I'm happy waiting until the end of the day, just to be sure.

I've been running BM with this patch for about 9 hours, now. It looks like the issue is resolved. Although I'm happy waiting until the end of the day, just to be sure.
Atheros1 commented 2013-07-01 19:05:29 +02:00 (Migrated from github.com)
Copy Link

Congratulations! You located the cause.

Congratulations! You located the cause.
rubo77 commented 2013-07-16 19:44:38 +02:00 (Migrated from github.com)
Copy Link

can I get a deb-package with that fix already somewhere?

can I get a deb-package with that fix already somewhere?
ghost commented 2013-07-16 19:52:14 +02:00 (Migrated from github.com)
Copy Link

http://download.opensuse.org/repositories/home:/motters:/pybitmessage/

http://download.opensuse.org/repositories/home:/motters:/pybitmessage/
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-23#277
No description provided.
Delete Branch "cpu100percentfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?