Bitmessage/PyBitmessage-2025-02-26
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 56 Actions Packages Projects Releases 5 Wiki Activity

"Mark all messages as read" causes critical error #1081

New Issue
Closed
opened 2017-11-28 20:10:35 +01:00 by g1itch · 7 comments
g1itch commented 2017-11-28 20:10:35 +01:00 (Migrated from github.com)
Copy Link

Hello!

I have 346 messages in [chan] bitmessage shown as unread. When I select "Mark all messages as read" context menu this causes PyBitmessage crash with many unicode characters dumped into console and finally the following messages:

Here is the actual error message thrown by the sqlThread: too many SQL variables
CRITICAL - This program shall now abruptly exit!

So I probably have SQLITE_MAX_VARIABLE_NUMBER < 999 in my system, but it seams there is no easy way to check the exact value.

The source

Hello! I have 346 messages in `[chan] bitmessage` shown as unread. When I select "Mark all messages as read" context menu this causes PyBitmessage crash with many unicode characters dumped into console and finally the following messages: > Here is the actual error message thrown by the sqlThread: too many SQL variables CRITICAL - This program shall now abruptly exit! So I probably have [SQLITE_MAX_VARIABLE_NUMBER](https://www.sqlite.org/limits.html#max_variable_number) < 999 in my system, but it seams there is no easy way to check the exact value. [The source](../blob/v0.6/src/bitmessageqt/__init__.py#L2536)
PeterSurda commented 2017-11-28 20:48:46 +01:00 (Migrated from github.com)
Copy Link

Thanks. I thought I fixed that. I think I should create a new function over sqlExecute which would handle this limit.

Thanks. I thought I fixed that. I think I should create a new function over sqlExecute which would handle this limit.
reelsense commented 2017-11-28 21:05:50 +01:00 (Migrated from github.com)
Copy Link

What version are you using @g1itch ?

What version are you using @g1itch ?
g1itch commented 2017-11-28 21:08:22 +01:00 (Migrated from github.com)
Copy Link

Latest PyBitmessage commit, Python 2.7.12, sqlite 3.19.3

Latest PyBitmessage commit, Python 2.7.12, sqlite 3.19.3
g1itch commented 2017-11-29 23:57:30 +01:00 (Migrated from github.com)
Copy Link

Hmm, I don't understand this:
if i % 999 == 999:

It seems to be always False

Hmm, I don't understand this: `if i % 999 == 999:` It seems to be always False
PeterSurda commented 2017-11-30 02:16:13 +01:00 (Migrated from github.com)
Copy Link

good catch.

good catch.
PeterSurda commented 2017-11-30 20:01:24 +01:00 (Migrated from github.com)
Copy Link

So I wrote a helper for this type of query (column in (x, x, x, x.....)) but have to test it.

So I wrote a helper for this type of query (column in (x, x, x, x.....)) but have to test it.
PeterSurda commented 2018-01-30 17:49:12 +01:00 (Migrated from github.com)
Copy Link

Fixed in 80fdb08f03

Fixed in 80fdb08f0369a86e4e65b740c0457b467fdff416
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
bug
Milestone
No items
No Milestone v0.6.3
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-26#1081
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?