Bitmessage/PyBitmessage-2025-02-26
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 56 Actions Packages Projects Releases 5 Wiki Activity

SQL statement error when deleting in QT interface #1504

New Issue
Closed
opened 2019-08-16 08:17:16 +02:00 by PeterSurda · 5 comments
PeterSurda commented 2019-08-16 08:17:16 +02:00 (Migrated from github.com)
Copy Link

2019-08-16 08:12:03,023 - CRITICAL - Major error occurred when trying to execute a SQL statement within the sqlThread. Please tell Atheros about this error mess age or post it in the forum! Error occurred while trying to execute statement: " DELETE FROM inbox" Here are the parameters; you might want to censor this data with asterisks (***) as it can contain private information: ('REDACTED',). Here is the actual error message thrown by the sqlThread: Incorrect number of bindings supplied. The current statement uses 0, and there are 1 supplied.

There was an independent report in a chan, but I somehow triggered it as well. @g1itch you did some refactoring with this recently, can you check it out?

`2019-08-16 08:12:03,023 - CRITICAL - Major error occurred when trying to execute a SQL statement within the sqlThread. Please tell Atheros about this error mess age or post it in the forum! Error occurred while trying to execute statement: " DELETE FROM inbox" Here are the parameters; you might want to censor this data with asterisks (***) as it can contain private information: ('REDACTED',). Here is the actual error message thrown by the sqlThread: Incorrect number of bindings supplied. The current statement uses 0, and there are 1 supplied.` There was an independent report in a chan, but I somehow triggered it as well. @g1itch you did some refactoring with this recently, can you check it out?
g1itch commented 2019-08-16 10:54:05 +02:00 (Migrated from github.com)
Copy Link

Where it appeared? While deleting from which folder? Because I cannot reproduce it by deleting from chan's inbox. And more strange there is no result for grep -r " DELETE FROM inbox" src. I cannot found delete statement with leading space.

Where it appeared? While deleting from which folder? Because I cannot reproduce it by deleting from chan's inbox. And more strange there is no result for `grep -r " DELETE FROM inbox" src`. I cannot found delete statement with leading space.
g1itch commented 2019-08-16 11:04:19 +02:00 (Migrated from github.com)
Copy Link

Oh, I see. You are deleting from trash. Maybe some regression in 0c1e5169

Oh, I see. You are deleting from trash. Maybe some regression in 0c1e5169
PeterSurda commented 2019-08-16 11:11:39 +02:00 (Migrated from github.com)
Copy Link

Yes, I believe it was from trash, but I'm not 100% sure.

Yes, I believe it was from trash, but I'm not 100% sure.
g1itch commented 2019-08-16 11:12:35 +02:00 (Migrated from github.com)
Copy Link
index 507e6ca0..2c5f1485 100644
--- a/src/bitmessageqt/__init__.py
+++ b/src/bitmessageqt/__init__.py
@@ -3270,8 +3270,8 @@ class MyForm(settingsmixin.SMainWindow):
             tableWidget.model().removeRows(r.topRow(), r.bottomRow()-r.topRow()+1)
         idCount = len(inventoryHashesToTrash)
         sqlExecuteChunked(
-            "DELETE FROM inbox" if folder == "trash" or shifted else
-            "UPDATE inbox SET folder='trash'"
+            ("DELETE FROM inbox" if folder == "trash" or shifted else
+             "UPDATE inbox SET folder='trash'") +
             " WHERE msgid IN ({0})", idCount, *inventoryHashesToTrash)
         tableWidget.selectRow(0 if currentRow == 0 else currentRow - 1)
         tableWidget.setUpdatesEnabled(True)

String literals does not stick together in this case as I expected. My bad.

```diff --git a/src/bitmessageqt/__init__.py b/src/bitmessageqt/__init__.py index 507e6ca0..2c5f1485 100644 --- a/src/bitmessageqt/__init__.py +++ b/src/bitmessageqt/__init__.py @@ -3270,8 +3270,8 @@ class MyForm(settingsmixin.SMainWindow): tableWidget.model().removeRows(r.topRow(), r.bottomRow()-r.topRow()+1) idCount = len(inventoryHashesToTrash) sqlExecuteChunked( - "DELETE FROM inbox" if folder == "trash" or shifted else - "UPDATE inbox SET folder='trash'" + ("DELETE FROM inbox" if folder == "trash" or shifted else + "UPDATE inbox SET folder='trash'") + " WHERE msgid IN ({0})", idCount, *inventoryHashesToTrash) tableWidget.selectRow(0 if currentRow == 0 else currentRow - 1) tableWidget.setUpdatesEnabled(True) ``` String literals does not stick together in this case as I expected. My bad.
PeterSurda commented 2019-08-16 11:13:46 +02:00 (Migrated from github.com)
Copy Link

That makes sense.

That makes sense.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-26#1504
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?